-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube link detection failed #23
Comments
looks like using === is causing the issue because it doesn't take account on return (
host === 'youtu.be' ||
(host === 'youtube.com' &&
pathname.includes('/watch') &&
Boolean(searchParams.get('v')))
); |
Hi @anuraghazra! Thanks for bringing this to my attention. |
@allcontributors Please add @anuraghazra for bugs |
I've put up a pull request to add @anuraghazra! 🎉 |
so basically all new URL(url).host === "my url" checks will be failing in this case |
🎉 This issue has been resolved in version 1.3.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
gatsby-remark-embedder
version: 1.3.1What you did:
trying to embed youtube video with www.youtube.com
What happened:
did not embed
Problem description:
https://youtube.com/watch?v=dQw4w9WgXcQ
is embedding correctly buthttps://www.youtube.com/watch?v=dQw4w9WgXcQ
is notSuggested solution:
Fixing
shouldTransform
functionThe text was updated successfully, but these errors were encountered: