Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Twitch): Fix Twitch embed #131

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix(Twitch): Fix Twitch embed #131

merged 1 commit into from
Jul 23, 2020

Conversation

MichaelDeBoey
Copy link
Owner

@MichaelDeBoey MichaelDeBoey commented Jul 22, 2020

As announced on their forum, Twitch updated the way the embedded video player is initiated.
This means we now have to pass a parent, which is a list of the domains your content appears on.

BREAKING CHANGE: You'll now need to pass a required parent option whenever you're using the Twitch service
BREAKING CHANGE: Twitch embeds can only be embedded on HTTPS websites. Check out the Gatsby
docs
for setting this up when developing locally.

Fixes #128

@MichaelDeBoey MichaelDeBoey added the ⚙︎ Twitch Issue or pull request regarding Twitch label Jul 22, 2020
@MichaelDeBoey MichaelDeBoey requested a review from kentcdodds July 22, 2020 14:45
@MichaelDeBoey MichaelDeBoey self-assigned this Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          215       220    +5     
  Branches        27        28    +1     
=========================================
+ Hits           215       220    +5     
Impacted Files Coverage Δ
src/transformers/Twitch.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77658d0...4879048. Read the comment docs.

README.md Show resolved Hide resolved
Copy link
Contributor

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I am not a maintainer but the chances look good to me to be honest. It might be worth mentioning that you can use localhost on a non-https site (but again I didn't have much luck with it), but it does make a lot of sense to mention it on the docs.

Also I would like to mention that I like the option for the config, it could also bring some help to other transformers in the future 🤔

BREAKING CHANGE: You'll now need to pass a required `parent` option whenever you're using the Twitch service
BREAKING CHANGE: Twitch embeds can only be embedded on HTTPS websites. Check out the Gatsby docs for setting this up when developing locally.
@MichaelDeBoey MichaelDeBoey merged commit 314de7e into master Jul 23, 2020
@MichaelDeBoey MichaelDeBoey deleted the fix-twitch branch July 23, 2020 10:03
@MichaelDeBoey
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released ⚙︎ Twitch Issue or pull request regarding Twitch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitch transformer will not work after new Twitch requirements
3 participants