Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): Log the URL that caused a failure #102

Merged
merged 7 commits into from
Mar 19, 2020

Conversation

kentcdodds
Copy link
Collaborator

The added context is very helpful.

It was easier to make a PR than open an issue. I'm afraid I don't have any more bandwidth for this though so I won't be working on adding tests or anything. Feel free to close if nobody else picks it up.

The added context is very helpful.
@kentcdodds kentcdodds marked this pull request as ready for review March 16, 2020 18:40
@MichaelDeBoey MichaelDeBoey added the enhancement New feature or request label Mar 16, 2020
@MichaelDeBoey MichaelDeBoey self-assigned this Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #102   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         176    179    +3     
  Branches       16     16           
=====================================
+ Hits          176    179    +3
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ce007...76dba9b. Read the comment docs.

@MichaelDeBoey MichaelDeBoey changed the title feat: log the URL that caused a failure. feat(plugin): Log the URL that caused a failure Mar 18, 2020
src/index.js Outdated Show resolved Hide resolved
MichaelDeBoey and others added 2 commits March 18, 2020 22:53
Co-Authored-By: Michal Piechowiak <misiek.piechowiak@gmail.com>
src/__tests__/plugin.js Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Owner

@pieh Are my changes what you were suggesting? 🤔

@pieh
Copy link
Contributor

pieh commented Mar 18, 2020

@pieh Are my changes what you were suggesting? 🤔

Yeah! exactly what I meant ;)

@MichaelDeBoey MichaelDeBoey merged commit da399e4 into master Mar 19, 2020
@MichaelDeBoey MichaelDeBoey deleted the kentcdodds-patch-1 branch March 19, 2020 13:01
@MichaelDeBoey
Copy link
Owner

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants