Internal function _getInheritedRoleNames() should return role object #304
Labels
enhancement
good first issue
This is an easy issue that beginners can tackle to get to know the code base.
meteor-roles/roles/roles_common.js
Lines 543 to 557 in 32c230d
The function
_getInheritedRoleNames()
is currently used to construct the arrayinheritedRoles
on a role-assignment, where it only takes over the parameter_id
. If you have data stored on the role, wouldn't it be better to have it copied along?If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.
The text was updated successfully, but these errors were encountered: