From 6c74506387a90cb374bc9054025df599a5c13be1 Mon Sep 17 00:00:00 2001 From: sethkfman Date: Thu, 7 Nov 2024 13:57:57 -0700 Subject: [PATCH 1/3] remove platform from other teams ownership --- .github/CODEOWNERS | 54 +++++++++++++++++++++++----------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4931485e00b..d8973ce826b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -15,46 +15,46 @@ app/util/metrics/ @MetaMask/mobile-platform app/components/hooks/useMetrics/ @MetaMask/mobile-platform # Supply Chain Team -bitrise.yml @MetaMask/supply-chain @MetaMask/mobile-platform -yarn.lock @MetaMask/supply-chain @MetaMask/mobile-platform -ios/Podfile.lock @MetaMask/supply-chain @MetaMask/mobile-platform +bitrise.yml @MetaMask/supply-chain +yarn.lock @MetaMask/supply-chain +ios/Podfile.lock @MetaMask/supply-chain # Ramps Team -app/components/UI/Ramp/ @MetaMask/ramp @MetaMask/mobile-platform -app/reducers/fiatOrders/ @MetaMask/ramp @MetaMask/mobile-platform +app/components/UI/Ramp/ @MetaMask/ramp +app/reducers/fiatOrders/ @MetaMask/ramp # Confirmation Team -app/components/Views/confirmations @MetaMask/confirmations @MetaMask/mobile-platform -ppom @MetaMask/confirmations @MetaMask/mobile-platform +app/components/Views/confirmations @MetaMask/confirmations +ppom @MetaMask/confirmations # All below files are maintained by the SDK team because they contain SDK related code, WalletConnect integrations, or critical SDK flows. -app/actions/sdk @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Approvals/WalletConnectApproval @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Views/SDK @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Views/WalletConnectSessions @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/BackgroundBridge/WalletConnectPort.ts @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/DeeplinkManager @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/RPCMethods/RPCMethodMiddleware.ts @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/SDKConnect @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/WalletConnect @MetaMask/sdk-devs @MetaMask/mobile-platform -app/reducers/sdk @MetaMask/sdk-devs @MetaMask/mobile-platform -app/util/walletconnect.js @MetaMask/sdk-devs @MetaMask/mobile-platform +app/actions/sdk @MetaMask/sdk-devs +app/components/Approvals/WalletConnectApproval @MetaMask/sdk-devs +app/components/Views/SDK @MetaMask/sdk-devs +app/components/Views/WalletConnectSessions @MetaMask/sdk-devs +app/core/BackgroundBridge/WalletConnectPort.ts @MetaMask/sdk-devs +app/core/DeeplinkManager @MetaMask/sdk-devs +app/core/RPCMethods/RPCMethodMiddleware.ts @MetaMask/sdk-devs +app/core/SDKConnect @MetaMask/sdk-devs +app/core/WalletConnect @MetaMask/sdk-devs +app/reducers/sdk @MetaMask/sdk-devs +app/util/walletconnect.js @MetaMask/sdk-devs # Accounts Team app/core/Encryptor/ @MetaMask/accounts-engineers # Swaps Team -app/components/UI/Swaps @MetaMask/swaps-engineers @MetaMask/mobile-platform +app/components/UI/Swaps @MetaMask/swaps-engineers # Notifications Team -app/components/Views/Notifications @MetaMask/notifications @MetaMask/mobile-platform -app/components/Views/Settings/NotificationsSettings @MetaMask/notifications @MetaMask/mobile-platform -app/components/UI/Notifications @MetaMask/notifications @MetaMask/mobile-platform -app/reducers/notification @MetaMask/notifications @MetaMask/mobile-platform -app/actions/notification @MetaMask/notifications @MetaMask/mobile-platform -app/selectors/notification @MetaMask/notifications @MetaMask/mobile-platform -app/util/notifications @MetaMask/notifications @MetaMask/mobile-platform -app/store/util/notifications @MetaMask/notifications @MetaMask/mobile-platform +app/components/Views/Notifications @MetaMask/notifications +app/components/Views/Settings/NotificationsSettings @MetaMask/notifications +app/components/UI/Notifications @MetaMask/notifications +app/reducers/notification @MetaMask/notifications +app/actions/notification @MetaMask/notifications +app/selectors/notification @MetaMask/notifications +app/util/notifications @MetaMask/notifications +app/store/util/notifications @MetaMask/notifications # LavaMoat Team ses.cjs @MetaMask/supply-chain From 4c068967fa7e35931184363a212073f8825acefc Mon Sep 17 00:00:00 2001 From: sethkfman Date: Thu, 7 Nov 2024 14:07:25 -0700 Subject: [PATCH 2/3] added 2 new files to the platform codeowners --- .github/CODEOWNERS | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d8973ce826b..d77ae9c05e8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -7,17 +7,14 @@ app/component-library/ @MetaMask/design-system-engineers # Platform Team +.github/CODEOWNERS @MetaMask/mobile-platform patches/ @MetaMask/mobile-platform app/core/Engine.ts @MetaMask/mobile-platform app/core/Engine.test.js @MetaMask/mobile-platform app/core/Analytics/ @MetaMask/mobile-platform app/util/metrics/ @MetaMask/mobile-platform app/components/hooks/useMetrics/ @MetaMask/mobile-platform - -# Supply Chain Team -bitrise.yml @MetaMask/supply-chain -yarn.lock @MetaMask/supply-chain -ios/Podfile.lock @MetaMask/supply-chain +app/store/migrations/ @MetaMask/mobile-platform # Ramps Team app/components/UI/Ramp/ @MetaMask/ramp From 6b1319322cb01842a2fa96a139a86feeaaba3e84 Mon Sep 17 00:00:00 2001 From: sethkfman Date: Fri, 22 Nov 2024 10:52:36 -0700 Subject: [PATCH 3/3] added dependency files for platform team --- .github/CODEOWNERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d77ae9c05e8..024e45a2f42 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -15,6 +15,9 @@ app/core/Analytics/ @MetaMask/mobile-platform app/util/metrics/ @MetaMask/mobile-platform app/components/hooks/useMetrics/ @MetaMask/mobile-platform app/store/migrations/ @MetaMask/mobile-platform +bitrise.yml @MetaMask/mobile-platform +yarn.lock @MetaMask/mobile-platform +ios/Podfile.lock @MetaMask/mobile-platform # Ramps Team app/components/UI/Ramp/ @MetaMask/ramp @@ -109,7 +112,6 @@ app/components/Views/QRAccountDisplay @MetaMask/wallet-ux app/components/Views/QRScanner @MetaMask/wallet-ux app/components/Views/Settings @MetaMask/wallet-ux app/components/Views/TermsAndConditions @MetaMask/wallet-ux - app/reducers/experimentalSettings @MetaMask/wallet-ux app/reducers/modals @MetaMask/wallet-ux app/reducers/navigation @MetaMask/wallet-ux