From 336238532707682cbebd1248fbf4ded184ad4393 Mon Sep 17 00:00:00 2001 From: Curtis Date: Tue, 22 Oct 2024 12:09:18 -0400 Subject: [PATCH 1/7] video recording --- .detoxrc.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.detoxrc.js b/.detoxrc.js index b1a80212b46..46f0b4441e1 100644 --- a/.detoxrc.js +++ b/.detoxrc.js @@ -1,7 +1,7 @@ /** @type {Detox.DetoxConfig} */ module.exports = { artifacts: { - rootDir: "./artifacts/screenshots", + rootDir: "./artifacts", plugins: { screenshot: { shouldTakeAutomaticSnapshots: true, @@ -9,10 +9,15 @@ module.exports = { takeWhen: { testStart: false, testDone: false, - } + }, + }, + video: { + enabled: true, // Enable video recording + keepOnlyFailedTestsArtifacts: true, // Keep only failed tests' videos }, }, }, + testRunner: { args: { $0: 'jest', From 7f489c5317d613e24e7b0565dd8618345277dd38 Mon Sep 17 00:00:00 2001 From: Curtis Date: Tue, 22 Oct 2024 16:56:01 -0400 Subject: [PATCH 2/7] update bitrise --- bitrise.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bitrise.yml b/bitrise.yml index 1fc61f98351..b6070b26b36 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -746,7 +746,7 @@ workflows: - content: |- #!/usr/bin/env bash set -ex - cp -r "$BITRISE_SOURCE_DIR/artifacts/screenshots" "$BITRISE_DEPLOY_DIR" + cp -r "$BITRISE_SOURCE_DIR/artifacts" "$BITRISE_DEPLOY_DIR" - deploy-to-bitrise-io@2.3: title: Deploy test screenshots is_always_run: true @@ -1004,7 +1004,7 @@ workflows: - content: |- #!/usr/bin/env bash set -ex - cp -r "$BITRISE_SOURCE_DIR/artifacts/screenshots" "$BITRISE_DEPLOY_DIR" + cp -r "$BITRISE_SOURCE_DIR/artifacts" "$BITRISE_DEPLOY_DIR" - deploy-to-bitrise-io@2.3: is_always_run: true run_if: .IsBuildFailed From 11f700c97f7846a21beff94f92c2d3a1d52b1242 Mon Sep 17 00:00:00 2001 From: Curtis Date: Tue, 22 Oct 2024 19:23:50 -0400 Subject: [PATCH 3/7] purposefully make tests fail to trigger video failure --- e2e/specs/networks/add-custom-rpc.spec.js | 2 +- e2e/specs/networks/add-popular-networks.spec.js | 2 +- ios/.ruby-version | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 ios/.ruby-version diff --git a/e2e/specs/networks/add-custom-rpc.spec.js b/e2e/specs/networks/add-custom-rpc.spec.js index a93af0334fd..1edbefdf845 100644 --- a/e2e/specs/networks/add-custom-rpc.spec.js +++ b/e2e/specs/networks/add-custom-rpc.spec.js @@ -55,7 +55,7 @@ describe(Regression('Custom RPC Tests'), () => { ); await NetworkView.tapRpcDropDownButton(); - await NetworkView.tapAddRpcButton(); + // await NetworkView.tapAddRpcButton(); await TestHelpers.delay(200); await NetworkView.typeInRpcUrl('abc'); // Input incorrect RPC URL diff --git a/e2e/specs/networks/add-popular-networks.spec.js b/e2e/specs/networks/add-popular-networks.spec.js index 05fbfa36a4b..3a3b407a02b 100644 --- a/e2e/specs/networks/add-popular-networks.spec.js +++ b/e2e/specs/networks/add-popular-networks.spec.js @@ -28,7 +28,7 @@ describe(Regression('Add all popular networks'), () => { await loginToApp(); await WalletView.tapNetworksButtonOnNavBar(); - await NetworkListModal.scrollToBottomOfNetworkList(); + // await NetworkListModal.scrollToBottomOfNetworkList(); await Assertions.checkIfVisible( NetworkListModal.addPopularNetworkButton, diff --git a/ios/.ruby-version b/ios/.ruby-version new file mode 100644 index 00000000000..9cec7165ab0 --- /dev/null +++ b/ios/.ruby-version @@ -0,0 +1 @@ +3.1.6 From 49fed1258c6061447126134f805c050458537011 Mon Sep 17 00:00:00 2001 From: Curtis Date: Wed, 23 Oct 2024 18:07:47 -0400 Subject: [PATCH 4/7] Revert "purposefully make tests fail to trigger video failure" This reverts commit 11f700c97f7846a21beff94f92c2d3a1d52b1242. --- e2e/specs/networks/add-custom-rpc.spec.js | 2 +- e2e/specs/networks/add-popular-networks.spec.js | 2 +- ios/.ruby-version | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 ios/.ruby-version diff --git a/e2e/specs/networks/add-custom-rpc.spec.js b/e2e/specs/networks/add-custom-rpc.spec.js index 1edbefdf845..a93af0334fd 100644 --- a/e2e/specs/networks/add-custom-rpc.spec.js +++ b/e2e/specs/networks/add-custom-rpc.spec.js @@ -55,7 +55,7 @@ describe(Regression('Custom RPC Tests'), () => { ); await NetworkView.tapRpcDropDownButton(); - // await NetworkView.tapAddRpcButton(); + await NetworkView.tapAddRpcButton(); await TestHelpers.delay(200); await NetworkView.typeInRpcUrl('abc'); // Input incorrect RPC URL diff --git a/e2e/specs/networks/add-popular-networks.spec.js b/e2e/specs/networks/add-popular-networks.spec.js index 3a3b407a02b..05fbfa36a4b 100644 --- a/e2e/specs/networks/add-popular-networks.spec.js +++ b/e2e/specs/networks/add-popular-networks.spec.js @@ -28,7 +28,7 @@ describe(Regression('Add all popular networks'), () => { await loginToApp(); await WalletView.tapNetworksButtonOnNavBar(); - // await NetworkListModal.scrollToBottomOfNetworkList(); + await NetworkListModal.scrollToBottomOfNetworkList(); await Assertions.checkIfVisible( NetworkListModal.addPopularNetworkButton, diff --git a/ios/.ruby-version b/ios/.ruby-version deleted file mode 100644 index 9cec7165ab0..00000000000 --- a/ios/.ruby-version +++ /dev/null @@ -1 +0,0 @@ -3.1.6 From 0cb299ebf0c1a9a959b3f640ccbd35c02e5a70bb Mon Sep 17 00:00:00 2001 From: Curtis Date: Wed, 23 Oct 2024 18:13:27 -0400 Subject: [PATCH 5/7] make tests in different workflows fail --- bitrise.yml | 6 +++--- e2e/specs/accounts/change-account-name.spec.js | 2 +- .../import-nft.failing.js => assets/import-nft.spec.js} | 0 e2e/specs/assets/nft-details.spec.js | 2 +- e2e/specs/confirmations/advanced-gas-fees.spec.js | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) rename e2e/specs/{quarantine/import-nft.failing.js => assets/import-nft.spec.js} (100%) diff --git a/bitrise.yml b/bitrise.yml index b6070b26b36..decc35273a8 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -132,7 +132,7 @@ stages: - android_e2e_build: {} run_smoke_e2e_ios_android_stage: workflows: - - run_ios_api_specs: {} + # - run_ios_api_specs: {} - run_tag_smoke_accounts_ios: {} - run_tag_smoke_accounts_android: {} # - run_tag_smoke_assets_ios: {} @@ -141,8 +141,8 @@ stages: - run_tag_smoke_confirmations_android: {} # - run_tag_smoke_swaps_ios: {} # - run_tag_smoke_swaps_android: {} - - run_tag_smoke_core_ios: {} - - run_tag_smoke_core_android: {} + # - run_tag_smoke_core_ios: {} + # - run_tag_smoke_core_android: {} build_regression_e2e_ios_android_stage: workflows: - ios_e2e_build: {} diff --git a/e2e/specs/accounts/change-account-name.spec.js b/e2e/specs/accounts/change-account-name.spec.js index f27e61fee52..14e58bd4226 100644 --- a/e2e/specs/accounts/change-account-name.spec.js +++ b/e2e/specs/accounts/change-account-name.spec.js @@ -50,7 +50,7 @@ describe(Regression('Change Account Name'), () => { EditAccountNameSelectorIDs.ACCOUNT_NAME_INPUT, NEW_ACCOUNT_NAME, ); - await EditAccountNameView.tapSave(); + // await EditAccountNameView.tapSave(); // Verify updated name await Assertions.checkIfElementToHaveText( diff --git a/e2e/specs/quarantine/import-nft.failing.js b/e2e/specs/assets/import-nft.spec.js similarity index 100% rename from e2e/specs/quarantine/import-nft.failing.js rename to e2e/specs/assets/import-nft.spec.js diff --git a/e2e/specs/assets/nft-details.spec.js b/e2e/specs/assets/nft-details.spec.js index a352684c7f9..fa62a361853 100644 --- a/e2e/specs/assets/nft-details.spec.js +++ b/e2e/specs/assets/nft-details.spec.js @@ -54,7 +54,7 @@ describe(SmokeAssets('NFT Details page'), () => { await Assertions.checkIfVisible( WalletView.nftInWallet(TEST_DAPP_CONTRACT), ); - await WalletView.tapOnNftName(); + // await WalletView.tapOnNftName(); await Assertions.checkIfTextIsDisplayed(enContent.nft_details.token_id); await Assertions.checkIfTextIsDisplayed( diff --git a/e2e/specs/confirmations/advanced-gas-fees.spec.js b/e2e/specs/confirmations/advanced-gas-fees.spec.js index 415179891b8..76ebec0ad81 100644 --- a/e2e/specs/confirmations/advanced-gas-fees.spec.js +++ b/e2e/specs/confirmations/advanced-gas-fees.spec.js @@ -52,7 +52,7 @@ describe(SmokeConfirmations('Advanced Gas Fees and Priority Tests'), () => { // Input acceptable value await AmountView.typeInTransactionAmount('0.00004'); - await AmountView.tapNextButton(); + // await AmountView.tapNextButton(); // Check that we are on the confirm view await Assertions.checkIfVisible( From e2c8210aa0d372795a942b5e717aed4b00f285a3 Mon Sep 17 00:00:00 2001 From: Curtis Date: Wed, 23 Oct 2024 19:10:14 -0400 Subject: [PATCH 6/7] Revert "make tests in different workflows fail" This reverts commit 0cb299ebf0c1a9a959b3f640ccbd35c02e5a70bb. --- bitrise.yml | 6 +++--- e2e/specs/accounts/change-account-name.spec.js | 2 +- e2e/specs/assets/nft-details.spec.js | 2 +- e2e/specs/confirmations/advanced-gas-fees.spec.js | 2 +- .../import-nft.spec.js => quarantine/import-nft.failing.js} | 0 5 files changed, 6 insertions(+), 6 deletions(-) rename e2e/specs/{assets/import-nft.spec.js => quarantine/import-nft.failing.js} (100%) diff --git a/bitrise.yml b/bitrise.yml index 73ba206a7e7..556a7b17c74 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -132,7 +132,7 @@ stages: - android_e2e_build: {} run_smoke_e2e_ios_android_stage: workflows: - # - run_ios_api_specs: {} + - run_ios_api_specs: {} - run_tag_smoke_accounts_ios: {} - run_tag_smoke_accounts_android: {} # - run_tag_smoke_assets_ios: {} @@ -141,8 +141,8 @@ stages: - run_tag_smoke_confirmations_android: {} # - run_tag_smoke_swaps_ios: {} # - run_tag_smoke_swaps_android: {} - # - run_tag_smoke_core_ios: {} - # - run_tag_smoke_core_android: {} + - run_tag_smoke_core_ios: {} + - run_tag_smoke_core_android: {} build_regression_e2e_ios_android_stage: workflows: - ios_e2e_build: {} diff --git a/e2e/specs/accounts/change-account-name.spec.js b/e2e/specs/accounts/change-account-name.spec.js index 9875e59f83b..f20c6ee3356 100644 --- a/e2e/specs/accounts/change-account-name.spec.js +++ b/e2e/specs/accounts/change-account-name.spec.js @@ -50,7 +50,7 @@ describe(Regression('Change Account Name'), () => { EditAccountNameSelectorIDs.ACCOUNT_NAME_INPUT, NEW_ACCOUNT_NAME, ); - // await EditAccountNameView.tapSave(); + await EditAccountNameView.tapSave(); // Verify updated name await Assertions.checkIfElementToHaveText( diff --git a/e2e/specs/assets/nft-details.spec.js b/e2e/specs/assets/nft-details.spec.js index fa62a361853..a352684c7f9 100644 --- a/e2e/specs/assets/nft-details.spec.js +++ b/e2e/specs/assets/nft-details.spec.js @@ -54,7 +54,7 @@ describe(SmokeAssets('NFT Details page'), () => { await Assertions.checkIfVisible( WalletView.nftInWallet(TEST_DAPP_CONTRACT), ); - // await WalletView.tapOnNftName(); + await WalletView.tapOnNftName(); await Assertions.checkIfTextIsDisplayed(enContent.nft_details.token_id); await Assertions.checkIfTextIsDisplayed( diff --git a/e2e/specs/confirmations/advanced-gas-fees.spec.js b/e2e/specs/confirmations/advanced-gas-fees.spec.js index b0b8932c08e..0771e671e65 100644 --- a/e2e/specs/confirmations/advanced-gas-fees.spec.js +++ b/e2e/specs/confirmations/advanced-gas-fees.spec.js @@ -72,7 +72,7 @@ describe(SmokeConfirmations('Advanced Gas Fees and Priority Tests'), () => { // Input acceptable value await AmountView.typeInTransactionAmount('0.00004'); - // await AmountView.tapNextButton(); + await AmountView.tapNextButton(); // Check that we are on the confirm view await Assertions.checkIfVisible( diff --git a/e2e/specs/assets/import-nft.spec.js b/e2e/specs/quarantine/import-nft.failing.js similarity index 100% rename from e2e/specs/assets/import-nft.spec.js rename to e2e/specs/quarantine/import-nft.failing.js From 355ac2fe6990b187767dd421803e3281222e9143 Mon Sep 17 00:00:00 2001 From: Curtis Date: Wed, 23 Oct 2024 19:35:32 -0400 Subject: [PATCH 7/7] rename zip for artifacts --- bitrise.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bitrise.yml b/bitrise.yml index 556a7b17c74..3b47f2039d6 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -754,7 +754,7 @@ workflows: inputs: - deploy_path: $BITRISE_DEPLOY_DIR - is_compress: true - - zip_name: E2E_Android_Failure_Screenshots + - zip_name: E2E_Android_Failure_Artifacts meta: bitrise.io: machine_type_id: elite-xl @@ -1012,7 +1012,7 @@ workflows: inputs: - deploy_path: $BITRISE_DEPLOY_DIR - is_compress: true - - zip_name: 'E2E_IOS_Failure_Screenshots' + - zip_name: 'E2E_IOS_Failure_Artifacts' start_e2e_tests: steps: - build-router-start@0: