Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap serialization error related to redux persist post swapping #9818

Closed
9 tasks
Cal-L opened this issue May 31, 2024 · 3 comments
Closed
9 tasks

Swap serialization error related to redux persist post swapping #9818

Cal-L opened this issue May 31, 2024 · 3 comments
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-swaps type-bug Something isn't working

Comments

@Cal-L
Copy link
Contributor

Cal-L commented May 31, 2024

What is this about?

There's currently a bug on main where an error stating redux-persist/createPersistoid:error serializing... occurs post swap. The error is thrown in redux-persist/lib/createPersistoid.js line 78 when it attempts to cache incoming data from Redux.

swap-persist-issue.mov

Scenario

  • Run the app on simulator
  • Import an account with a native balance
  • Perform a swap action on mainnet or linea mainnet
  • Notice that the redux-persist error appears
  • The error continues to appear even after dismissal since the app continues to serialize + cache data occasionally

Design

No response

Technical Details

  • Investigate the data changes post swap. Serialization works prior to a swap, which implies some data changes may be failing to serialize post swap

Threat Modeling Framework

No response

Acceptance Criteria

  • Error disappears after swapping

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

@NicolasMassart
Copy link
Contributor

  • does this prevent swap to work properly?
  • once the error happened, is it popping again even if we restart app?

@gauthierpetetin gauthierpetetin added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 8, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-swaps type-bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants