Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectible detection sometimes doesn't work #980

Closed
bdresser opened this issue Aug 1, 2019 · 2 comments · Fixed by #993
Closed

Collectible detection sometimes doesn't work #980

bdresser opened this issue Aug 1, 2019 · 2 comments · Fixed by #993
Assignees
Labels
type-bug Something isn't working

Comments

@bdresser
Copy link
Contributor

bdresser commented Aug 1, 2019

e.g.

The wallet doesn't auto populate if a new 721 is received. It requires contract address and token Id manually. This seems like a very bad solution, especially if say, I was trying to send a business card NFT to someone, the only way they could see it in metamask mobile is by looking up the address and the token Id via txhash.... Then see the card. Whereas trust wallet just autopopulates using an Api call.

It would be great if erc20 tokens are automatically recognized. I had to import the token address in order for metamask to show the custom token I had created and set to myself.
Additionally I love that we are able to transfer collectibles from the collectible tab!g

perhaps this isn't a bug just a fact of how we implement collectibles? if so, we should have a way to let users know some collectibles aren't autodetected.

@bdresser bdresser added type-bug Something isn't working needs-reproduction labels Aug 1, 2019
@vikmeup
Copy link

vikmeup commented Aug 1, 2019

Please add automagically feature to see all your collectables. 🚀

@estebanmino estebanmino self-assigned this Aug 8, 2019
@estebanmino
Copy link
Contributor

fix in MetaMask/core#138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants