Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Transfer an ERC20 token from a dapp mixes transfer with approve screen #6606

Closed
seaona opened this issue Jun 14, 2023 · 1 comment
Closed

[Bug] Transfer an ERC20 token from a dapp mixes transfer with approve screen #6606

seaona opened this issue Jun 14, 2023 · 1 comment
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.2.0 release-7.2.0 Issue or pull request that will be included in release 7.2.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Jun 14, 2023 •
edited
Loading

Describe the bug
Whenever I try to transfer an ERC20 token I can see how MM displays an Approve warning an a mixed screen between a transfer an an approve.
Seems that the wallet entered into a weird state where a cascade of issues occurred.

Screenshots

approve-warning-for-send-erc20.mp4

To Reproduce
Steps to reproduce the behavior
See video -- but need to find consistent steps

Expected behavior
An ERC20 transfer should display the transfer custom screen

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android
  • App Version: 7.2.0

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 14, 2023
@seaona seaona mentioned this issue Jun 14, 2023
Merged
3 tasks
@seaona
Copy link
Contributor Author

seaona commented Jun 30, 2023 •
edited
Loading

After this issue #6608 was fixed by this PR, the subsequent related issues have been fixed too. So this issue can be closed

@seaona seaona closed this as completed Jun 30, 2023
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.2.0 release-7.2.0 Issue or pull request that will be included in release 7.2.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metamaskbot @seaona