Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When attempting to connect MM wallet to the portfolio through in-app browser, the connecting modal displays the message "null wants to:" #12990

Open
sleepytanya opened this issue Jan 15, 2025 · 3 comments
Labels
regression-prod-7.37.1 Regression bug that was found in production in release 7.37.1 regression-prod-7.39.0 Regression bug that was found in production in release 7.39.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-sdk SDK team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

When attempting to connect MM wallet to the portfolio through in-app browser, the connecting modal displays the message "null wants to:" instead of "portfolio.metamask.io wants to:"

Bug was found in v7.37.1, not present in the RC v7.38.0(1524)

Expected behavior

Correct message should be displayed

Screenshots/Recordings

Null is shown instead of portfolio.metamask.io:

null_portfolio_video.MP4
Image

RC 7.38.0(1524) - bug is not present:

Android

Screen_Recording_20250114_203933_MetaMask.mp4

iOS

ScreenRecording_01-14-2025.20-44-37_1.MP4

Steps to reproduce

  1. Open in-app browser
  2. Connect MetaMask to Portfolio
  3. Observe message on the connection modal

Error messages or log output

Detection stage

In production (default)

Version

7.37.1

Build type

None

Device

other

Operating system

iOS

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-portfolio type-bug Something isn't working labels Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 15, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 15, 2025
@metamaskbot metamaskbot added regression-prod-7.37.1 Regression bug that was found in production in release 7.37.1 and removed regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 labels Jan 15, 2025
@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jan 15, 2025

RC 7.38.0 still has this issue when utilizing external browser.

Steps to reproduce:

  1. connect to metamask using walletconnect from a system browser (chrome, firefox...)
  2. when connect request appears on MetaMask app, press cancel
  3. open inApp Browser and navigate to metamask portfolio dapp
  4. Press connect and see modal with null value
null-connect.mov

@joaoloureirop
Copy link
Contributor

Issue still present on v.7.39.0

Tagging sdk team to take a look

here's more context on the root cause

@joaoloureirop joaoloureirop added team-sdk SDK team regression-prod-7.39.0 Regression bug that was found in production in release 7.39.0 and removed team-portfolio labels Feb 11, 2025
@Unik0rnMaggie
Copy link
Contributor

Reproduced on Android Redmi 9, (Android 12), v7.41.0 (1586):

Null.dapps.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.37.1 Regression bug that was found in production in release 7.37.1 regression-prod-7.39.0 Regression bug that was found in production in release 7.39.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-sdk SDK team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be triaged
Development

No branches or pull requests

5 participants
@metamaskbot @sleepytanya @Unik0rnMaggie @joaoloureirop and others