Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Stop throwing error in Sentry when user tries to add a chain with unrecognized rpc url #11731

Open
sentry-io bot opened this issue Oct 10, 2024 · 5 comments · May be fixed by #13182
Open

Error: Stop throwing error in Sentry when user tries to add a chain with unrecognized rpc url #11731

sentry-io bot opened this issue Oct 10, 2024 · 5 comments · May be fixed by #13182
Assignees
Labels
area-Sentry Issue from Sentry Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform Mobile Platform team type-bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Oct 10, 2024

Sentry Issue: METAMASK-MOBILE-2DVH

Error: {"code":4100,"message":"Request blocked due to spam filter."}
  at ?anon_0_ (app/util/Logger/index.ts:83:32)
...
(11 additional frame(s) were not displayed)

Steps to reproduce:

  • Go to https://bridge.coredao.org/coreBTC
  • Click on "Add coreBTC to your wallet"
  • MM will throw "Unrecognized chain ID "0x45c". Try adding the chain using wallet_addEthereumChain first."

Here we throw a Sentry error while we'd like to send and Error event in Segment instead.

@gauthierpetetin gauthierpetetin added type-bug Something isn't working area-Sentry Issue from Sentry labels Oct 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Oct 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Oct 10, 2024
@gauthierpetetin gauthierpetetin added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform Mobile Platform team labels Oct 10, 2024
@gauthierpetetin
Copy link
Contributor

By the way, we don't seem to be throwing the error in Extension as I don't find any error when searching for "Unrecognized chain ID" is Sentry. We might want to take inspiration of the way it's handled in the Extension codebase.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jan 8, 2025
@gauthierpetetin gauthierpetetin removed the stale Issues that have not had activity in the last 90 days label Jan 8, 2025
@frankvonhoven frankvonhoven self-assigned this Jan 24, 2025
@frankvonhoven
Copy link
Contributor

I think this is where
they handle that error on extension

@smilingkylan
Copy link
Contributor

smilingkylan commented Mar 7, 2025

Also throws this error at times. Sentry seems to think it's the same issue.

Error: {"code":-32002,"message":"Request of type 'wallet_requestPermissions' already pending for origin infinifi.xyz. Please wait."}
at ?anon_0_ (app/util/Logger/index.ts:83:32)
...
(11 additional frame(s) were not displayed)

#13911

@gauthierpetetin
Copy link
Contributor

Same os for unrecognised chainId, it seems we need to throw the error for the dapp without throwing it to Sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry Issue from Sentry Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform Mobile Platform team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be triaged
3 participants