From 5363983aaee32412a977e97afc1dc7447bc97738 Mon Sep 17 00:00:00 2001 From: Samuel Salas Date: Wed, 24 Apr 2024 13:35:08 -0600 Subject: [PATCH] Fix flaky tests --- .../Contacts/AddContactView.selectors.js | 1 + .../permission-system-delete-wallet.spec.js | 2 +- ...-system-revoking-multiple-accounts.spec.js | 20 ------------------- 3 files changed, 2 insertions(+), 21 deletions(-) diff --git a/e2e/selectors/Settings/Contacts/AddContactView.selectors.js b/e2e/selectors/Settings/Contacts/AddContactView.selectors.js index d3c676548cf..e984a9c4964 100644 --- a/e2e/selectors/Settings/Contacts/AddContactView.selectors.js +++ b/e2e/selectors/Settings/Contacts/AddContactView.selectors.js @@ -13,4 +13,5 @@ export const AddContactViewSelectorsIDs = { export const AddContactViewSelectorsText = { EDIT_BUTTON: enContent.address_book.edit, EDIT_CONTACT: enContent.address_book.edit_contact, + MEMO: enContent.address_book.memo, }; diff --git a/e2e/specs/permission-systems/permission-system-delete-wallet.spec.js b/e2e/specs/permission-systems/permission-system-delete-wallet.spec.js index 51143411c23..bb07caa5d36 100644 --- a/e2e/specs/permission-systems/permission-system-delete-wallet.spec.js +++ b/e2e/specs/permission-systems/permission-system-delete-wallet.spec.js @@ -95,7 +95,7 @@ describe( await Browser.isVisible(); await Browser.tapNetworkAvatarButtonOnBrowser(); await Assertions.checkIfNotVisible(ConnectedAccountsModal.title); - await Assertions.checkIfVisible(NetworkListModal.testSwitch); + await Assertions.checkIfVisible(NetworkListModal.testNetToggle); }, ); }); diff --git a/e2e/specs/permission-systems/permission-system-revoking-multiple-accounts.spec.js b/e2e/specs/permission-systems/permission-system-revoking-multiple-accounts.spec.js index 866656ea803..8e5776f90ac 100644 --- a/e2e/specs/permission-systems/permission-system-revoking-multiple-accounts.spec.js +++ b/e2e/specs/permission-systems/permission-system-revoking-multiple-accounts.spec.js @@ -3,7 +3,6 @@ import TestHelpers from '../../helpers'; import Browser from '../../pages/Browser'; import AccountListView from '../../pages/AccountListView'; import TabBarComponent from '../../pages/TabBarComponent'; -import ConnectModal from '../../pages/modals/ConnectModal'; import ConnectedAccountsModal from '../../pages/modals/ConnectedAccountsModal'; import { loginToApp } from '../../viewHelper'; import NetworkListModal from '../../pages/modals/NetworkListModal'; @@ -11,9 +10,6 @@ import FixtureBuilder from '../../fixtures/fixture-builder'; import { withFixtures } from '../../fixtures/fixture-helper'; import Assertions from '../../utils/Assertions'; -const SUSHI_SWAP = 'https://app.sushi.com/swap'; -const SUSHI_SWAP_SHORT_HAND_URL = 'app.sushi.com'; - describe('Connecting to multiple dapps and revoking permission on one but staying connected to the other', () => { beforeAll(async () => { jest.setTimeout(150000); @@ -35,17 +31,6 @@ describe('Connecting to multiple dapps and revoking permission on one but stayin await TabBarComponent.tapBrowser(); await Browser.isVisible(); - // should connect to sushi swap dapp - await Browser.tapUrlInputBox(); - await Browser.navigateToURL(SUSHI_SWAP); - await Assertions.checkIfVisible(ConnectModal.container); - await ConnectModal.scrollToBottomOfModal(); - await Assertions.checkIfNotVisible(ConnectModal.container); - await TabBarComponent.tapBrowser(); - - // should connect with multiple accounts - await Browser.tapOpenAllTabsButton(); - await Browser.tapOpenNewTabButton(); await Browser.navigateToTestDApp(); await Browser.isAccountToastVisible('Account 1'); await Browser.tapNetworkAvatarButtonOnBrowserWhileAccountIsConnectedToDapp(); @@ -69,11 +54,6 @@ describe('Connecting to multiple dapps and revoking permission on one but stayin await Assertions.checkIfVisible(NetworkListModal.networkScroll); await NetworkListModal.swipeToDismissModal(); await Assertions.checkIfNotVisible(NetworkListModal.networkScroll); - await TestHelpers.delay(3500); - await Browser.tapOpenAllTabsButton(); - await TestHelpers.tapByText(SUSHI_SWAP_SHORT_HAND_URL); - await Browser.tapNetworkAvatarButtonOnBrowserWhileAccountIsConnectedToDapp(); - await Assertions.checkIfVisible(NetworkListModal.networkScroll); }, ); });