Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Denied Transaction Error doesn't get caught in callback function although it logs by inpage.js in console. #4434

Closed
AntonCorbijn opened this issue May 31, 2018 · 11 comments
Assignees

Comments

@AntonCorbijn
Copy link

Bug Reports:
After installed latest version (4.7.0) of Metamask, when rejecting transaction, MetaMask throws error "User denied transaction signature" by inpage.js in chrome console but it was not caught in callback as exception.

  • Expected Behavior
    I would expect to catch the error inside of callback. For example
    TestContract.callFunction({from: defaultAddress}, function (err, res) {
    // handle err here
    console.log(err)
    });
  • Actual Behavior
    I got nothing from console.log(err) although I can see "User denied transaction signature" error log by inpage.js in console.
  • Browser Used
    Chrome V66.0.3359.181
  • Operating System Used
    OSX 10.11.6
    screen shot 2018-05-31 at 9 26 03 pm
@Artod
Copy link

Artod commented Jun 1, 2018

Same issue

@andrewsource147
Copy link

Same, team please look at this. I added try catch but it didn't work

@Arctek
Copy link

Arctek commented Jun 1, 2018

This breaks a number of dApps as it leaves them in an unresolved state, waiting for the promise to fulfill or throw.

@wjmelements wjmelements self-assigned this Jun 1, 2018
@jjingrong
Copy link

+1
This was working pre 4.7.0

@wjmelements
Copy link
Contributor

Perhaps 71a6e97

@wjmelements
Copy link
Contributor

I will try a build that reverts #4384

@yuxulong00
Copy link

Same issue

@wjmelements
Copy link
Contributor

wjmelements commented Jun 1, 2018

I am somewhat confident that this is related to createErrorMiddleware from #4245

@wjmelements
Copy link
Contributor

whoops it's from ce28344, not 4245

@wjmelements
Copy link
Contributor

#4199

@wjmelements wjmelements assigned bitpshr and unassigned wjmelements Jun 1, 2018
@wjmelements
Copy link
Contributor

This is a dupe of #4431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants