Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editing flow #26635

Open
wants to merge 103 commits into
base: develop
Choose a base branch
from
Open

feat: Editing flow #26635

wants to merge 103 commits into from

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Aug 23, 2024

This PR is to add editing flow while switching networks via dapp
NOTE: This PR doesn't include tests

Related issues

Fixes:

  1. https://github.com/MetaMask/MetaMask-planning/issues/2683
  2. https://github.com/MetaMask/MetaMask-planning/issues/2684
  3. https://github.com/MetaMask/MetaMask-planning/issues/2697
  4. https://github.com/MetaMask/MetaMask-planning/issues/2698
  5. https://github.com/MetaMask/MetaMask-planning/issues/2663

Manual testing steps

  1. run the extension with CHAIN_PERMISSIONS flag
  2. Connect to a dapp
  3. Switch network via metamask
  4. toast should show up
  5. Then click on edit permissions, it should route to new permissions screen
  6. We have edit networks and edit accounts modal there

Screenshots/Recordings

Before

NA

After

Screen.Recording.2024-09-04.at.5.05.21.PM.mov
Screen.Recording.2024-09-04.at.5.27.57.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi dismissed stale reviews from adonesky1 and themself via 0dc84aa September 18, 2024 21:59
@NidhiKJha
Copy link
Member Author

NidhiKJha commented Sep 18, 2024

Overall looks pretty good. I have a few questions before giving the go-ahead to merge. There are also some comments from myself and Jony that went unanswered.

I have addressed all your comments in the commits but my bad forgot to reply, apologies for that. Had addressed Jony's comment in this message #26635 (comment) but addressed them separately as well.

Lastly, I'm wondering if some of the data management that's appearing inside components should either be moved to a helper function or a selector.

I have tried to create selectors for most of the functions that are used in multiple components. But can take a look and move the data management to selectors

adonesky1
adonesky1 previously approved these changes Sep 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d065a0c]
Page Load Metrics (1826 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16332327181014368
domContentLoaded16222116177511153
load16312352182615374
domInteractive13255636933
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.17 KiB (0.03%)
  • ui: 28.06 KiB (0.39%)
  • common: 5.68 KiB (0.07%)

@metamaskbot
Copy link
Collaborator

Builds ready [5eff06e]
Page Load Metrics (1939 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16352386194218689
domContentLoaded16262381191019091
load16352386193918890
domInteractive208044189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.17 KiB (0.03%)
  • ui: 28.37 KiB (0.39%)
  • common: 5.76 KiB (0.07%)

jiexi and others added 5 commits September 19, 2024 13:50
# Conflicts:
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js
#	app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js
#	ui/components/multichain/edit-networks-modal/edit-networks-modal.js
#	ui/components/multichain/network-list-menu/network-list-menu.js
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.9% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants