-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editing flow #26635
base: develop
Are you sure you want to change the base?
feat: Editing flow #26635
Conversation
8ff52ad
to
da2478a
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
34e3b54
to
acaddf8
Compare
I have addressed all your comments in the commits but my bad forgot to reply, apologies for that. Had addressed Jony's comment in this message #26635 (comment) but addressed them separately as well.
I have tried to create selectors for most of the functions that are used in multiple components. But can take a look and move the data management to selectors |
ui/components/multichain/pages/review-permissions-page/review-permissions-page.tsx
Dismissed
Show dismissed
Hide dismissed
Builds ready [d065a0c]
Page Load Metrics (1826 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5eff06e]
Page Load Metrics (1939 ± 90 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
# Conflicts: # app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js # app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js # ui/components/multichain/edit-networks-modal/edit-networks-modal.js # ui/components/multichain/network-list-menu/network-list-menu.js
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This PR is to add editing flow while switching networks via dapp
NOTE: This PR doesn't include tests
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
NA
After
Screen.Recording.2024-09-04.at.5.05.21.PM.mov
Screen.Recording.2024-09-04.at.5.27.57.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist