Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MetaMetricsController (implementation + tests) to TypeScript #25924

Open
1 of 9 tasks
mcmire opened this issue Jul 18, 2024 · 0 comments
Open
1 of 9 tasks

Convert MetaMetricsController (implementation + tests) to TypeScript #25924

mcmire opened this issue Jul 18, 2024 · 0 comments
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Jul 18, 2024

What is this about?

As a prerequisite for migrating MetaMetricsController to BaseController v2, and to support the TypeScript migration effort for the extension, we want to convert MetaMetricsController to TypeScript.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

  • All functions and methods are annotated with argument and return types.
  • All properties and free variables are annotated with types.
  • # is used for private properties and methods instead of _.
  • The test file is converted to TypeScript along with the implementation file.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jul 18, 2024
@desi desi removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Sep 6, 2024
@cryptodev-2s cryptodev-2s self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants