Convert AlertController to TypeScript

[mcmire]

What is this about?

As a prerequisite for migrating AlertController to BaseController v2, and to support the TypeScript migration effort, we want to convert AlertController to TypeScript.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

• All functions and methods are annotated with argument and return types.
• All free variables are annotated with types.
• # is used for private properties and methods instead of _.
• The functionality supported by this controller still works. (There are no tests for this controller, so that may have to be checked manually.)

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

• Convert partial level 3 files to typescript for contributing to metamask-controller.js #23017