Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace EnsController with core EnsController #23223

Closed
2 of 18 tasks
cryptodev-2s opened this issue Feb 28, 2024 · 1 comment
Closed
2 of 18 tasks

Replace EnsController with core EnsController #23223

cryptodev-2s opened this issue Feb 28, 2024 · 1 comment
Assignees
@cryptodev-2s
Labels
team-wallet-framework

Comments

@cryptodev-2s
Copy link
Contributor

What is this about?

What is this about?

Following the successful merge of EnsController from the extension to the core Existing EnsController as detailed in MetaMask/core#1129, we should now fully remove the EnsController logic from the extension and instead rely entirely on the core monorepo implementation.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@cryptodev-2s cryptodev-2s self-assigned this Feb 28, 2024
@mcmire
Copy link
Contributor

mcmire commented Mar 4, 2024

Closed via #23224.

@mcmire mcmire closed this as completed Mar 4, 2024
@MajorLift MajorLift mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcmire @cryptodev-2s