Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the TokenBalancesController to track token balances #19226

Open
Gudahtt opened this issue May 19, 2023 · 0 comments
Open

Use the TokenBalancesController to track token balances #19226

Gudahtt opened this issue May 19, 2023 · 0 comments

Comments

@Gudahtt
Copy link
Member

Gudahtt commented May 19, 2023

The extension currently tracks token balances in the UI. Instead it should use the shared TokenBalancesController to track token balances in the background. This lets us avoid making separate network requests in each window, saving on network bandwidth.

The UI token balance tracking is clever about only being active when the balances are actively being viewed though. We should investigate ways to ensure network traffic does not increase with this change (i.e. only ask for balance updates when they are needed).

This relates to MetaMask/core#700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@Gudahtt @anaamolnar and others