From 3fe78b1ac89c01dd77f36ce761ed071aa3578a20 Mon Sep 17 00:00:00 2001 From: Ramon AC <36987446+racitores@users.noreply.github.com> Date: Wed, 15 Jan 2025 16:04:04 +0100 Subject: [PATCH] test: MMQA-188: remove mmi e2e tests from ci (#29233) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MMI e2e tests are not longer maintained so they need to be removed from ci: - Remove CI (only this in this PR due to the urgency of the change) Create a new PR to remove the next points: - Remove Docs - **node dependencies** - Remove e2e/tests - Remove e2e/tests/playwright - Remove references in scripts - Remove stuff not in the code base like https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/116332/workflows/e18a49f4-f111-4728-abc8-23d46b93feb6/jobs/4357634 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29233?quickstart=1) Fixes: 1. Go to this page... 2. 3. - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- .circleci/config.yml | 3 --- .circleci/scripts/release-create-gh-release.sh | 4 ---- 2 files changed, 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c83da321a2ed..6d04a1de6c37 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1349,9 +1349,6 @@ jobs: - run: name: Publish Flask MV2 release to Sentry command: yarn sentry:publish --build-type flask --dist mv2 - - run: - name: Publish MMI release to Sentry - command: yarn sentry:publish --build-type mmi - run: name: Create GitHub release command: .circleci/scripts/release-create-gh-release.sh diff --git a/.circleci/scripts/release-create-gh-release.sh b/.circleci/scripts/release-create-gh-release.sh index 29118f57b756..d8ade6686ec6 100755 --- a/.circleci/scripts/release-create-gh-release.sh +++ b/.circleci/scripts/release-create-gh-release.sh @@ -61,7 +61,6 @@ if [[ $current_commit_msg =~ Version[-[:space:]](v[[:digit:]]+.[[:digit:]]+.[[:d then tag="${BASH_REMATCH[1]}" flask_version="$(print_build_version 'flask')" - mmi_version="$(print_build_version 'mmi')" install_github_cli @@ -72,15 +71,12 @@ then --attach builds-mv2/metamask-firefox-*.zip \ --attach builds-flask/metamask-flask-chrome-*.zip \ --attach builds-flask-mv2/metamask-flask-firefox-*.zip \ - --attach builds-mmi/metamask-mmi-chrome-*.zip \ - --attach builds-mmi/metamask-mmi-firefox-*.zip \ --message "Version ${tag##v}" \ --message "$release_body" \ --commitish "$CIRCLE_SHA1" \ "$tag" publish_tag 'Flask' "${flask_version}" - publish_tag 'MMI' "${mmi_version}" else printf '%s\n' 'Version not found in commit message; skipping GitHub Release' exit 0