Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template to design tokens repo #590

Closed
georgewrmarshall opened this issue Jan 19, 2024 · 1 comment
Closed

Add PR template to design tokens repo #590

georgewrmarshall opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
code Issue related to code work documentation Improvements or additions to documentation team-design-system All issues relating to design system

Comments

@georgewrmarshall
Copy link
Collaborator

Description

We need to create a PR template that can be used for all design token PRs and aligns with mobile and extension codebases.

Technical Details

  • Add .github/PULL_REQUEST_TEMPLATE.md that aligns with mobile and the extension

Acceptance Criteria

  • The PR template should include sections for: Description, Issue #, Testing Steps, Screenshots, Design Tokens (if applicable), and Additional Information.
  • The PR template should specifically ask for testing steps and screenshots in both mobile and extension environments if the PR involves changes to the design tokens.
  • The PR template should be usable in both the mobile and extension repositories.

Additional Information

Once the PR template is created, it should be added to the .github directory in both the mobile and extension

@georgewrmarshall georgewrmarshall added documentation Improvements or additions to documentation code Issue related to code work team-design-system All issues relating to design system labels Jan 19, 2024
@georgewrmarshall georgewrmarshall self-assigned this Jan 19, 2024
@georgewrmarshall
Copy link
Collaborator Author

georgewrmarshall commented Feb 1, 2024

Closed by #601 here 5210fff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Issue related to code work documentation Improvements or additions to documentation team-design-system All issues relating to design system
Projects
None yet
Development

No branches or pull requests

1 participant