You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Historically, the providerConfig property in NetworkController has been used to switch and track the currently selected network as well as provide access to information about that network. That is now achieved with a combination of the selectedNetworkClientId and networkConfigurations properties as well as the configuration property on the NetworkClient interface. This means that we no longer need providerConfig and we can remove this redundant state.
Removing providerConfig is one thing, but there are also a ton of packages which make use of this property to access the currently selected chain, and we would want to make use of selectedNetworkClientId in combination with the NetworkController:getNetworkClientById action to do this instead.
Acceptance Criteria
providerConfig is removed from NetworkController (replaced with selectedNetworkClientId and/or `networkConfigurations); NetworkController tests pass
[assets-controllers] AccountTrackerController is updated to follow suit and tests pass
[assets-controllers] AssetsContractController is updated to follow suit and tests pass
[assets-controllers] NftController is updated to follow suit and tests pass
[assets-controllers] NftDetectionController is updated to follow suit and tests pass
[assets-controllers] TokensController is updated to follow suit and tests pass
[assets-controllers] TokenListController is updated to follow suit and tests pass
[assets-controllers] TokenRatesController is updated to follow suit and tests pass
EnsController is updated to follow suit and tests pass
GasFeeController is updated to follow suit and tests pass
SelectedNetworkController tests are updated to follow suit and tests pass
TransactionController is updated to follow suit and tests pass
The text was updated successfully, but these errors were encountered:
Historically, the
providerConfig
property in NetworkController has been used to switch and track the currently selected network as well as provide access to information about that network. That is now achieved with a combination of theselectedNetworkClientId
andnetworkConfigurations
properties as well as theconfiguration
property on the NetworkClient interface. This means that we no longer needproviderConfig
and we can remove this redundant state.Removing
providerConfig
is one thing, but there are also a ton of packages which make use of this property to access the currently selected chain, and we would want to make use ofselectedNetworkClientId
in combination with theNetworkController:getNetworkClientById
action to do this instead.Acceptance Criteria
providerConfig
is removed from NetworkController (replaced withselectedNetworkClientId
and/or `networkConfigurations); NetworkController tests passAccountTrackerController
is updated to follow suit and tests passAssetsContractController
is updated to follow suit and tests passNftController
is updated to follow suit and tests passNftDetectionController
is updated to follow suit and tests passTokensController
is updated to follow suit and tests passTokenListController
is updated to follow suit and tests passTokenRatesController
is updated to follow suit and tests passEnsController
is updated to follow suit and tests passGasFeeController
is updated to follow suit and tests passSelectedNetworkController
tests are updated to follow suit and tests passTransactionController
is updated to follow suit and tests passThe text was updated successfully, but these errors were encountered: