Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate keyring interactions on extension and mobile #1101

Closed
Gudahtt opened this issue Feb 15, 2023 · 1 comment
Closed

Consolidate keyring interactions on extension and mobile #1101

Gudahtt opened this issue Feb 15, 2023 · 1 comment

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Feb 15, 2023

Today both extension and mobile use the eth-keyring-controller package, but they each have their own wrapper methods for safely interacting with this underlying keyring controller. These wrapper functions handle things like:

  • Keeping other controller state in-sync with keyring state
  • Input parsing
  • Setup and cleanup steps for hardware wallets
  • Routing messages between the keyring controller and the message signing controllers

Mobile has these wrapper functions in @metamask/keyring-controller, but extension has them as part of metamask-extension.js. Most of the functionality is similar between the two, but there are many differences as well.

We should consolidate this code between extension and mobile where possible, so that both projects are using @metamask/keyring-controller. We can normalize the behavior between them both where possible. In cases where we do need some project-specific code, we can migrate that into the client repositories directly.

@desi
Copy link

desi commented Aug 1, 2024

All issues closed, closing the epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants