Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp template description does not match with files generated #560

Open
aranega opened this issue Sep 7, 2022 · 4 comments
Open

Webapp template description does not match with files generated #560

aranega opened this issue Sep 7, 2022 · 4 comments
Labels
bug Something isn't working scope:code-generation

Comments

@aranega
Copy link
Member

aranega commented Sep 7, 2022

When the webapp template is used, the backend directory is not generated.

Running:

harness-application webapp-example -t webapp

Generates the following files tree:

webapp-example
├── api
│   ├── config.json
│   └── openapi.yaml
├── backend
│   └── webapp_example
│       └── __main__.py
├── deploy
│   └── values.yaml
├── Dockerfile
├── frontend
│   ├── build.yaml
│   ├── package.json
│   ├── package-lock.json
│   ├── README.md
│   ├── src
│   │   ├── App.tsx
│   │   ├── assets
│   │   │   └── icon.png
│   │   ├── components
│   │   │   └── RestTest.tsx
│   │   ├── index.ejs
│   │   ├── index.tsx
│   │   ├── rest
│   │   │   ├── api.ts
│   │   │   ├── base.ts
│   │   │   ├── common.ts
│   │   │   ├── configuration.ts
│   │   │   ├── git_push.sh
│   │   │   └── index.ts
│   │   ├── styles
│   │   │   └── style.less
│   │   └── utils
│   │       └── history.js
│   ├── tsconfig.json
│   ├── webpack.config.dev.js
│   └── webpack.config.js
├── README.md
└── test
    ├── api
    │   └── test_st.py
    └── e2e
        └── landing.spec.ts

We can see that the backend folder only contains a directory with a __main__.py file in it.

However harness-application --help mentions that:

- webapp (webapp including backend and frontend).
@aranega aranega added the bug Something isn't working label Sep 7, 2022
@zsinnema
Copy link
Contributor

zsinnema commented Sep 7, 2022

@aranega this seems correct behaviour to me. You should specify the backend type: Flask or Django

@zsinnema zsinnema closed this as completed Sep 7, 2022
@aranega
Copy link
Member Author

aranega commented Sep 7, 2022

Ah, ok :), sorry for the issue @zsinnema !
The thing then is that harness-application --help is confusing as it yields: - webapp (webapp including backend and frontend).

@afonsobspinto afonsobspinto changed the title Generating project structure with "webapp" template does not generate the backend Webapp template description does not match with files generated Sep 7, 2022
@afonsobspinto
Copy link
Member

I'm reopening the issue after re-framing it with @aranega's last comment information

@afonsobspinto afonsobspinto reopened this Sep 7, 2022
@filippomc
Copy link
Collaborator

Agree the command help and the docs should mention this, otherwise it's not really working as expected by the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:code-generation
Projects
None yet
Development

No branches or pull requests

4 participants