Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed download requests #3644

Closed
tomasMizera opened this issue Oct 10, 2024 · 1 comment · Fixed by #3673
Closed

Retry failed download requests #3644

tomasMizera opened this issue Oct 10, 2024 · 1 comment · Fixed by #3673
Assignees
Labels
enhancement sync Integration with Mergin Maps backend
Milestone

Comments

@tomasMizera
Copy link
Collaborator

tomasMizera commented Oct 10, 2024

Syncing big projects in areas with low data coverage or often network issues can be challenging.

We want to implement a mechanism to retry requests after network error or different server errors.
Requests should be retried in case of network error and server 5xx http codes.

This ticket is only about project download, not about uploading chunks. Uploading is a bit more tricky and will be part of a different ticket.

Note: we already have sync retries in place, but this ticket applies to individual requests during sync.

Let's not retry more than 5 times for now (as a total in transaction).

Related issues #885, #1308

@alexd0793
Copy link

Tried on android and iOS. While downloading a bug project, i turned off the internet connection, and after turning back on, i saw in the logs the retries.
On windows not able yet to test, because of an issue with the app( i cannot go to see the logs). But victor is aware of it, once it's not an issue anymore i will close this testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sync Integration with Mergin Maps backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants