Can't use app tokens since #326

[TrishGillett]

👋 We're experiencing a regression in the ability to use app keys beginning with this PR. This is the error:

  File \"/project/.meltano/extractors/tap-github/venv/lib/python3.10/site-packages/tap_github/authenticator.py\", line 130, in generate_app_access_token
    jwt_token = generate_jwt_token(github_app_id, github_private_key)
  File \"/project/.meltano/extractors/tap-github/venv/lib/python3.10/site-packages/tap_github/authenticator.py\", line 116, in generate_jwt_token
    token = jwt.encode(payload, github_private_key, algorithm=algorithm)
  File \"/project/.meltano/extractors/tap-github/venv/lib/python3.10/site-packages/jwt/api_jwt.py\", line 74, in encode
    return api_jws.encode(
  File \"/project/.meltano/extractors/tap-github/venv/lib/python3.10/site-packages/jwt/api_jws.py\", line 160, in encode
    alg_obj = self.get_algorithm_by_name(algorithm_)
  File \"/project/.meltano/extractors/tap-github/venv/lib/python3.10/site-packages/jwt/api_jws.py\", line 99, in get_algorithm_by_name
    raise NotImplementedError(
NotImplementedError: Algorithm 'RS256' could not be found. Do you have cryptography installed?

The issue does not happen if I peg the tap-github version to (v1.8.0). Pegging to any newer commits causes the issue to happen, the first such commit being the merge commit for #326. @edgarrmondragon do you know of anything in the singer-sdk 0.35.2 -> 0.42.1 updates that could be related to this problem? Maybe something changing dependency handling?

[edgarrmondragon]

Hey @TrishGillett, thanks for reporting!

I think we might just need an explicit dependency on cryptography. I'll have a PR shortly.

[edgarrmondragon]

#350

[edgarrmondragon]

v1.11.1 is tagged. Thanks @TrishGillett!