Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - Add _sdc_repository as an identifier for relevant fields? #22

Closed
ericboucher opened this issue Sep 20, 2021 · 2 comments
Closed

Comments

@ericboucher
Copy link
Contributor

ericboucher commented Sep 20, 2021

Singer's GitHub tap is adding an _sdc_repository field for streams that don't get it from the API as an easy-to-use identifier to streams to their parent repo.

See https://github.com/singer-io/tap-github/blob/master/tap_github/__init__.py#L927

Should we do something similar with the Meltano taps?

At the moment, repo and org keys get added, so we could decide to leverage that instead.

One caveat, some streams actually have fields called repo and org that could be incompatible (see my upcoming Events stream PR).

@aaronsteers
Copy link
Contributor

aaronsteers commented Sep 20, 2021

Hi, @ericboucher. I haven't looked in advance at what the overloaded repo and org fields would contain in the other stream. We imagined those repo and org attributes to be generic and pretty much universal, unless there's a reason to do otherwise. (Renaming would cause some headache at this point but I don't think it's fully off the table.)

Ideally I'd like to keep _sdc_ columns to be reserved for a for a specific global set of Singer Data Capture metadata columns like those enumerated here: https://sdk.meltano.com/en/latest/implementation/record_metadata.html

Personally, I have considered a generic a _sdc_parent_keys column or sdc_partition_context, or similar, but I'd like to stay away from the _sdc_repository name since that is specifically unique to tap-github.

@ericboucher
Copy link
Contributor Author

This was solved by introducing the repo_id field in #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants