[49.3][StratCon] 50% Preserve objective consistently fails when 100% Preserve objective is successful

[StowGnar]

Environment

Windows 10, MekHQ Version 0.49.3 (8/17/21 CI artifact), megameklog.txt says Java 16.0.1

Description

I've seen this issue happen multiple times in my campaign, but it occurs as follows: the few times I actually succeed and keep 100% of a protected allied integrated force alive and achieve the Preserve 100% objective, I seem to be unable to gain both it and the Preserve 50% objective, resulting in a net neutral VP gain. The issue is that the Preserve 50% objective seems to be permanently red and failed. No amount of rearranging check marks seems to change this; only Preserve 100% can be changed by check marks at this point. A screenshot is in the attached package, along with a save and salvage MUL. A save post-results is also included, in case anything can be pulled from that. I stupidly forgot to branch a copy of the logs before I continued playing, so I'm not sure if the included logs will be of any use. Thankfully it is at least easy to reproduce this error as follows:

1. Load campaign file labelled "beforebuggedbattle".
2. Resolve Manually on current day's Scenario and load included MUL.
3. Click through to the end and see same situation as in screenshot.

Thanks for all you guys do!

Files

Multiple Preserve Objective Fail Bug.zip

[mnahkola]

Happened to me on 0.48.0 stable as well.

Not the only kind of objective completion problem I've had, either - not being able to complete the "reach edge" objective is actually more common. (Especially if the battle ends because the enemies are all dead before I've reached the objective edge.)

Poking at the checkboxes does nothing in that case as well, so I'd guess this is not specific to objective type.

(Had an error uploading my screenshot etc... oh well.)

[mnahkola]

So yeah, apparently this was reported earlier as one of the sub-issues of #2575 - is it that rare for other people or otherwise hard to reproduce? Happens to me pretty regularly on 0.48.0 stable, with very different scenarios.

I'm running on OpenJDK 11 JRE on Linux, in case that makes a difference. Specifically "OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.18.04)"

[SerBeardian]

Issue still exists in .50
Further information:
Scenario generates requiring 100% preservation of lone ally mech, plus a 50% preservation of friendly forces.
Upon completion, the 50% preservation mission has only the ally mech, and is impossible to complete, resulting in point loss.
Appears that HQ allocates a specific lance to this objective, assuming that the lance will be deployed, but does not automatically allocate this lance to the mission due to Stratcon deployment.
Testing results:

• When the correct lance is allocated, the objective can be completed.
  
• When the requested lance is not allocated, the objective cannot be completed.
  
• Reducing the required % to be preserved to 20% (1/5 units - so just the solo mech out of mech+lance) allows this objective to be completed even with the requested lance not deployed, so it obviously checks against what forces should be in there, even if it's not actually part of the scenario.
• Regenerating bot forces will quickly reset this objective, along with ally/enemy forces.
• The designated force to be preserved can be altered manually by editing the scenario objective to align with the correct deployed forces, if ally/enemy forces need to be preserved.

Log:
mekhq.log
Save:
Meatbag Malcontents30210814.cpnx.gz

[IllianiCBT]

I think this will be resolved by #4928, but it will need testing once that PR has been merged so I won't close this PR right now.