Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt xbridge to our Open Source Standards #12

Closed
javihern98 opened this issue Feb 12, 2025 · 0 comments · Fixed by #16
Closed

Adapt xbridge to our Open Source Standards #12

javihern98 opened this issue Feb 12, 2025 · 0 comments · Fixed by #16
Assignees
@guillegrc
Labels
optimisation Code styling and development enhancements

Comments

@javihern98
Copy link
Contributor

Overview

We would like to align xbridge to our current standards on Open Source software. This includes styling and typing, as well as some efforts on automatic testing.

Tasks to perform

  • Add ruff and mypy
  • Define expected quota for code coverage (currently is at 75%, no automatic tests on Taxonomy loader, but manual tests shows it works fine)
  • Style the code using ruff format and ruff check --fix
  • Add ruff checks on testing CI
@javihern98 javihern98 self-assigned this Feb 12, 2025
@javihern98 javihern98 added the optimisation Code styling and development enhancements label Feb 12, 2025
@javihern98 javihern98 assigned guillegrc and unassigned javihern98 Feb 13, 2025
@javihern98 javihern98 changed the title Adapt library to our Open Source Standards Adapt xbridge to our Open Source Standards Feb 15, 2025
@javihern98 javihern98 linked a pull request Feb 20, 2025 that will close this issue
Open source standards refactor #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillegrc guillegrc

Labels
optimisation Code styling and development enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open source standards refactor Meaningful-Data/xbridge
2 participants
@javihern98 @guillegrc