favicon: add light & dark option for OS's prefered color scheme #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlindsay42
commented
Jun 1, 2023
tlindsay42
commented
- Closes favicon: add light & dark option for OS's preferred color scheme #549
McShelby
reviewed
Jun 1, 2023
layouts/partials/favicon.html
Outdated
| {{- if (fileExists "/static/images/favicon-dark.svg") }} | ||
| <link href="{{ "images/favicon-dark.svg" | relURL }}{{ if $assetBusting }}?{{ now.Unix }}{{ end }}" rel="icon" type="image/svg+xml" media="(prefers-color-scheme: dark)"> | ||
| {{- end }} | ||
| {{- else if (fileExists "/static/images/favicon.svg") }} |
There was a problem hiding this comment.
This should also be supported for the other file types. Not just SVG
Because this would mean to duplicate a lot of code, the better way would be to refactor the code using a parameterized inline template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.