Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs: fix wrapping when having many tabs #272

Closed
morduun opened this issue Jun 13, 2022 · 3 comments
Closed

tabs: fix wrapping when having many tabs #272

morduun opened this issue Jun 13, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@morduun
Copy link

morduun commented Jun 13, 2022

When a tab selector has more than one page-width worth of tabs and the presentation shifts to two or more rows of tabs, the location of the second and further rows of tabs changes (shifting horizontally) based on the location of the tab clicked on the row above.

It's a little messy to explain - following video shows exactly what I'm talking about much more effectively.

2022-06-13.16-24-22.mp4
@McShelby
Copy link
Owner

Well sounds like a tough one... I am not sure my CSS-foo is that good, so any help appriciated.

@McShelby McShelby added the bug Something isn't working label Jun 14, 2022
@McShelby McShelby changed the title presentation broken: tabs with more than one page-width worth of tabs tabs: fix wrapping when having many tabs Jun 14, 2022
@morduun
Copy link
Author

morduun commented Jun 14, 2022

Hahaha yeah my css-foo is pretty abysmal, figured I might at least lob it upstream to see if anyone knew any easy fixes before I dove in. Let me tinker for a bit and see what I can come up with, if there's anything useful I'll do a pull req and let you know. It looks like some kind of [iterator] -1 issue but it's almost never what it seems like at first.

@McShelby
Copy link
Owner

Tabs are never looking good if they got wrapped to the next line, but at least I could fix the error of the moving tab handles

@McShelby McShelby self-assigned this Jun 23, 2022
@McShelby McShelby added this to the 4.2.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants