Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform support for windows and msvc compiler #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RalfOGit
Copy link

Thanks for your great library. It works like a charm. I had to change a number of things to get it to work on windows and to let it compile without warnings with the msvc compiler. Please have look and, choose what you like and ignore what you don't like,

@Mazurel
Copy link
Owner

Mazurel commented Oct 13, 2024

Thanks a lot for this!
Sorry for ignoring it for so long, I was pretty busy, but now I want to refresh this project a little bit 😄

I will look at this PR and try to merge your changes soon

@Mazurel Mazurel added the enhancement New feature or request label Oct 13, 2024
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Co-authored-by: RalfOGit <https://github.com/RalfOGit>
Co-authored-by: MightyPiggie <https://github.com/MightyPiggie>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit <https://github.com/RalfOGit>
Co-authored-by: MightyPiggie <https://github.com/MightyPiggie>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit <https://github.com/RalfOGit>
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Oct 27, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
Mazurel added a commit that referenced this pull request Nov 10, 2024
Thanks for contributions from:
- RalfOGit <https://github.com/RalfOGit>
- MightyPiggie <https://github.com/MightyPiggie>

PR: #5

Co-authored-by: RalfOGit
Co-authored-by: MightyPiggie <daansmienk10@gmail.com>
Signed-off-by: Mateusz Mazur <mateusz.mazur@e.email>
@Mazurel Mazurel mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants