Issue adding check without VersionChange

[micah686]

Related to PR #1 , I have a question on how I should proceed with a PR.

I added the following code to CompareVersions

          //....  
          github = NormalizeVersionString(github);



            var currentValid = Version.TryParse(current, out var currentVersion);
            var githubValid = Version.TryParse(github, out var githubVersion);
            bool validVersion = currentValid && githubValid;

            if (validVersion && cmpType != CompareType.Boolean && changeLevel <= VersionChange.Revision)
            {
                return currentVersion < githubVersion;
            }
            else
            {
                // choose CompareType specific compare method
                switch (cmpType)
                {
                    case CompareType.Incremental:
                        return CompareVersionsIncremental(current, github, changeLevel);

                    // boolean is fallback, because it accepts the widest range of input
                    case CompareType.Boolean:
                    default:
                        return CompareVersionsBoolean(current, github);
                }
            }

However, your test TestExceedLocalDepth() checks for a false value if the Version Change is Minor, but since my code change checks against the whole version, it returns true, causing the test to fail. Do you have any suggestions how I can modify the changes to make sure it passes the tests?

[Mayerch1]

I'm not entirely sure.

What do you think about modifying NormalizeVersionString.
A new parameter VersionChange could cut off all unused decimals in the version, using some regex or similiar.

However this takes away some of the parsing capabilities of the Version class.

But I don't see another way of solving this, as this is an important behaviour (not updating in that test case)