Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops scanning randomly #9

Closed
Yishaqel opened this issue Jan 31, 2014 · 14 comments
Closed

Stops scanning randomly #9

Yishaqel opened this issue Jan 31, 2014 · 14 comments
Labels

Comments

@Yishaqel
Copy link

When trying to scan using the latest version was quickly stopped with the previous version works correctly.

@Maxx53
Copy link
Owner

Maxx53 commented Jan 31, 2014

It's simple fix. You need to disallow errors, that breaks scan cycle

@Yishaqel
Copy link
Author

I'm sorry, could you tell me how to fix it? I did not understand what you said and I do not understand too much English.

@Maxx53
Copy link
Owner

Maxx53 commented Jan 31, 2014

File /scr/SCMBot/SteamSite.cs
Strings 607 and 616.

@Yishaqel
Copy link
Author

Ok thanks mate :)

@Maxx53
Copy link
Owner

Maxx53 commented Jan 31, 2014

Added fix.

@Maxx53 Maxx53 closed this as completed Jan 31, 2014
@istishlah
Copy link

by saying added fix you say its included in the latest precompiled version ? or do i have to take the src and compile it myself to add this fix ? greetings

@Maxx53
Copy link
Owner

Maxx53 commented Feb 20, 2014

Fix already in source and binary.

@istishlah
Copy link

hmm, if its allready in there, i must say in wont help with randomly stopping scans :)
i tested the last 3 nights. There was just 1-2 items which were still scanning after 8 hours of sleep. All the others stopped 30mins - 60mins after i went to sleep :/

@Maxx53
Copy link
Owner

Maxx53 commented Feb 20, 2014

Sleeping threads is another problem.
I don't know the reason why is this happening, but I think possible to solve this problem in future.

@istishlah
Copy link

maybe put in something like ttl for scans ? like every scan gets a TTL of 500 scans or such. Then ttl x scan time (3000ms) = time to check if thread is sleeping and if it is, close it and restart. Or something like add up 1 counter for each scan and for each output and if they differ the thread gets restarted, just loud thinking ^^

@zuhaib2002
Copy link

this thing really needs fixing..
this problem is more painful then having a bad tooth

@Maxx53
Copy link
Owner

Maxx53 commented Feb 24, 2014

For health reasons I had to stop project development. Be patient.

@Maxx53 Maxx53 reopened this Feb 24, 2014
@zuhaib2002
Copy link

Get well soon mate, Health comes first :)

@istishlah
Copy link

i wish you all the best, allways health first, cant agree more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants