Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show slider value tooltip without having to click first #3628

Open
vertigo220 opened this issue Jul 8, 2024 · 2 comments
Open

Show slider value tooltip without having to click first #3628

vertigo220 opened this issue Jul 8, 2024 · 2 comments
Labels
Milestone

Comments

@vertigo220
Copy link

Bug explanation

I submitted an issue to FanControl which is, per its developer, related to this project. When using the mouse scroll wheel to change a slider, the value tooltip doesn't show unless clicking the slider first. I suppose this could be intended behavior, but it would be nice to have an option to always show the value when changing it without having to click first.

Version

5.0

@vertigo220 vertigo220 added bug evaluation required Items is pending review or evaluation by the team labels Jul 8, 2024
@Keboo Keboo removed the evaluation required Items is pending review or evaluation by the team label Jul 11, 2024
@Keboo Keboo added this to the 5.2.0 milestone Jul 11, 2024
@Keboo
Copy link
Member

Keboo commented Jul 11, 2024

Did some investigation into this.

Reproduction steps. In the demo app click on the "tracks" (repeat buttons) above or below the slider thumb. Note that the value changes but the tooltip is not shown until you click on the thumb itself.

It appears that the issue is clicking on the repeat buttons does not move focus to the Slider.

@corvinsz
Copy link
Contributor

corvinsz commented Oct 11, 2024

Some more info on this:

When setting IsMoveToPointEnabled to True in the style for the Slider, there is additional code executed before the actual base.OnPreviewMouseLeftButtonDown(e);. I assume that is the issue with this bug.
For reference see: https://source.dot.net/#PresentationFramework/System/Windows/Controls/Slider.cs,773

Simply setting IsMoveToPointEnabled to False works, however this would impact the UX since - as the name implies - you can't jump to a value on the track with a single click anymore:
SliderClickbug

I created a branch here if someone wants to fiddle around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants