fix(snapshot): fixed snapshots always created in testza directory #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshots work only within
testza
itself and when used in another module, try to create a fixture file within thetestza
dir (which results in no permission).This PR fixes a nesting issue in the snapshot support by extracting internal logic to a shared function (thus normalizing the stack trace).
Affected:
SnapshotCreateOrValidate
SnapshotCreate
PS. A regression test calling from another module would be nice, but not sure how to hook it up to the main
go test
.