Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]: Should I fix unrecognized manifest key in this project? #200

Closed
BlackHole1 opened this issue Sep 6, 2021 · 10 comments
Closed

Comments

@BlackHole1
Copy link
Contributor

BlackHole1 commented Sep 6, 2021

Many people in the community are currently experiencing the following error:

(node:22308) ExtensionLoadWarning: Warnings loading extension at xxx:
  Unrecognized manifest key 'browser_action'.
  Unrecognized manifest key 'minimum_chrome_version'.
  Unrecognized manifest key 'short_name'.
  Unrecognized manifest key 'update_url'.
  Permission 'activeTab' is unknown or URL pattern is malformed.
  Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.

The reason for this error is due to the combination of chromium and electron

I have submitted a PR for the fix to electron and it has been merged as well, see: electron/electron#29695

However, it is not clear which version of this PR will be carried. electron@v16.x

As a project affected by this issue do much, should we fix it temporarily in the project?

just like this: #177

@BlackHole1
Copy link
Contributor Author

This is a community project, so I wanted to discuss the feasibility with you all before submitting a PR.

@MarshallOfSound @brunos3d @dewinterjack @agentschmitt

@BlackHole1
Copy link
Contributor Author

Here's a list of my statistics on encountering this problem:

#197
#182
#149
#143
#141
#165

@twosaturdayscode
Copy link

It would be great! Even tho it doesn't block anything it's always annoying to ignore warnings.

@agentschmitt
Copy link

i aggree thats annoying to ignore warnings and it seems the fix to electron wilkl be on v16 only so it would be nice to have the fix for devtools too.

@chase
Copy link

chase commented Sep 21, 2021

We're stuck on an older version of Electron for the time being, so I agree with @agentschmitt

I would like to see this merged still: #177

@BlackHole1

This comment has been minimized.

@MarshallOfSound
Copy link
Owner

Advertising other modules to capitalize off of SEO of an existing module is bad form. Please do not do so, I'd normally let it slide but doing it across multiple issues shows clear intent.

@BlackHole1
Copy link
Contributor Author

Advertising other modules to capitalize off of SEO of an existing module is bad form. Please do not do so, I'd normally let it slide but doing it across multiple issues shows clear intent.

👌🏻 sorry, I didn't mean to do that. you have a point.

@BlackHole1
Copy link
Contributor Author

so, may I ask how you feel about this issue? If I could, I wouldn't need to maintain another library.

@BlackHole1
Copy link
Contributor Author

I would like to know what is the reason why you have not made any comments about #177 and this issue so far?
Because 267 days have passed since I brought this up and you have not made any comments.
Although the project is personal to you and open source itself represents freedom.
Wouldn't it be more polite if you could respond to comments?

I'm not moral coercion, I just have some questions about your long period of non-response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants