-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion]: Should I fix unrecognized manifest key
in this project?
#200
Comments
This is a community project, so I wanted to discuss the feasibility with you all before submitting a PR. |
It would be great! Even tho it doesn't block anything it's always annoying to ignore warnings. |
i aggree thats annoying to ignore warnings and it seems the fix to electron wilkl be on v16 only so it would be nice to have the fix for devtools too. |
We're stuck on an older version of Electron for the time being, so I agree with @agentschmitt I would like to see this merged still: #177 |
This comment has been minimized.
This comment has been minimized.
Advertising other modules to capitalize off of SEO of an existing module is bad form. Please do not do so, I'd normally let it slide but doing it across multiple issues shows clear intent. |
👌🏻 sorry, I didn't mean to do that. you have a point. |
so, may I ask how you feel about this issue? If I could, I wouldn't need to maintain another library. |
I would like to know what is the reason why you have not made any comments about #177 and this issue so far? I'm not moral coercion, I just have some questions about your long period of non-response. |
Many people in the community are currently experiencing the following error:
The reason for this error is due to the combination of chromium and electron
I have submitted a PR for the fix to electron and it has been merged as well, see: electron/electron#29695
However, it is not clear which version of this PR will be carried.electron@v16.xAs a project affected by this issue do much, should we fix it temporarily in the project?
just like this: #177
The text was updated successfully, but these errors were encountered: