-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not throw ResizeObserver loop limit exceeded errors #40
Comments
@Maximaximum Ultimately the With that said, I appreciate you pointing this out, and I will take a closer look. |
Adding this here for posterity. Avoid ResizeObserver loop limit exceeded. The issues surfaces on Chrome version >=64.
Reference: WICG/resize-observer#38 Eventually the error may be turned into a warning via w3c Issue#5023.. in lieu of having that as a viable solution, I am working on the recommended fix mentioned by the OP. |
@Maximaximum Please run v1.1.8 through its paces, and feel free to re-open this issue if the problem has not been resolved. |
Even though the
README.md
explicitly mentions that theResizeObserver loop limits exceeded error
can be ignored, this does not seem to be a proper behavior. The error should not be thrown at all instead. This can be easily achieved by wrapping theResizeObserver
constructor callback with arequestAnimationFrame()
call.The problem with current implementation is that we have a global error handler. The handler ensures that the app fails on any unhandled exception, and sends the error to the Sentry endpoint so that we can monitor all the unhandled errors that occur while using the app.
While in the handler we could check if an error message contains a “ResizeObserver” string, or has exactly a specific error message string, and ignore it in such case, this is not a best practice scalable and manageable solution.
Besides, we might want to be informed on
ResizeObserver
errors that occur in other places in the app, but not in the container query polyfill.The text was updated successfully, but these errors were encountered: