Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] G61 does not return to saved position when Axis specified without an offset #26222

Closed
1 task done
karcaw opened this issue Sep 3, 2023 · 7 comments · Fixed by #27281
Closed
1 task done

[BUG] G61 does not return to saved position when Axis specified without an offset #26222

karcaw opened this issue Sep 3, 2023 · 7 comments · Fixed by #27281
Labels
Fix Included A fix is included in the description

Comments

@karcaw
Copy link
Contributor

karcaw commented Sep 3, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When you use the G61 Return to Saved Position feature, and specify any axis to restore, and do not put a offset value, it does not return to the saved location, it does not change that axis at all. It stems from Line 89:

destination[i] = parser.seen(AXIS_CHAR(i))
? stored_position[slot][i] + parser.value_axis_units((AxisEnum)i)
: current_position[i];

Which defaults to the current position, and not to stored_position[slot][i] as it should.

The online line documentation here: https://marlinfw.org/docs/gcode/G061.html
does not even mention that offsets are an option, so anyone using this command with axis restores is bound to fail.(As I did)

Bug Timeline

In the original code of G61 (#16557)

Expected behavior

I expect it to move back to the proper position.

Actual behavior

It does not move

Steps to Reproduce

for Example if you run:

G28
G0 X10 Y10 Z10
G60
G0 X100 Y100 Z20
G61 X Y  

No movement is seen on the G61. if instead you change that to G61 X0 Y0 it will properly move back to the X10 Y10 position.
a bare G61 does work properly.

Version of Marlin Firmware

Marlin 2.1.2

Printer model

Creality Ender 3 Pro

Electronics

Stock 4.2.2 Board

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

OctoPrint

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

EF8_G16Debug.zip

@karcaw
Copy link
Contributor Author

karcaw commented Nov 2, 2023

yup, still valid

@karcaw
Copy link
Contributor Author

karcaw commented Feb 1, 2024

yup, still valid

@karcaw
Copy link
Contributor Author

karcaw commented May 31, 2024

still not fixed

@karcaw
Copy link
Contributor Author

karcaw commented Jul 16, 2024

Any chance we can get this merged?

@thisiskeithb
Copy link
Member

Any chance we can get this merged?

Since you've provided a fix, please open a proper Pull Request for review.

See Contributing Code with Pull Requests for more details.

@thisiskeithb thisiskeithb added the Fix Included A fix is included in the description label Jul 16, 2024
@karcaw
Copy link
Contributor Author

karcaw commented Jul 16, 2024

I made one,... Seems I pointed it at the wrong master: karcaw#1

@karcaw
Copy link
Contributor Author

karcaw commented Jul 16, 2024

Added proper PR

@thisiskeithb thisiskeithb linked a pull request Jul 17, 2024 that will close this issue
@MarlinFirmware MarlinFirmware deleted a comment from github-actions bot Jul 17, 2024
@MarlinFirmware MarlinFirmware deleted a comment from github-actions bot Jul 17, 2024
@MarlinFirmware MarlinFirmware deleted a comment from github-actions bot Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Included A fix is included in the description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants