-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Marlin bugfix-2.1.x Not compiling correctly since 3 weeks ago - BTT Octopus Pro V1.1 board #27221
Comments
Minimal Config to trigger this issue #define MOTHERBOARD BOARD_BTT_OCTOPUS_PRO_V1_1 set #define TEMP_SENSOR_0 1 and #define HEATER_0_MAXTEMP 275 and it builds! |
Seems to be #27111 Added Marlin/src/HAL/STM32/dogm/u8g_com_stm32duino_swspi.cpp which is being activated when it shouldn't be |
I think this should be the fix, but need to recheck it when im a bit more awake, Your configs now build with this patch. diff --git a/Marlin/src/HAL/STM32/dogm/u8g_com_stm32duino_swspi.cpp b/Marlin/src/HAL/STM32/dogm/u8g_com_stm32duino_swspi.cpp
index 68c6430538..93733d8165 100644
--- a/Marlin/src/HAL/STM32/dogm/u8g_com_stm32duino_swspi.cpp
+++ b/Marlin/src/HAL/STM32/dogm/u8g_com_stm32duino_swspi.cpp
@@ -24,7 +24,7 @@
#include "../../../inc/MarlinConfig.h"
-#if ALL(HAS_MARLINUI_U8GLIB, FORCE_SOFT_SPI)
+#if ENABLED(SKR_MINI_SCREEN_ADAPTER) && ALL(HAS_MARLINUI_U8GLIB, FORCE_SOFT_SPI)
#include <U8glib-HAL.h>
#include "../../shared/HAL_SPI.h"
|
Great news. Thank you very much! |
Although this is a workaround I notice that this code is replicated on 3 different platforms, so It needs further investigation. |
Ok, will put this workaround on my branch until it gets resolved on the upstream branch. Thank you again. |
So after using this workaround for sometime I noticed that the LCD screen control does not work. I did not noticed this problem before because I was using Octo Print. To resolve this problem I reverted the commit for "SW SPI Mode 3 for U8G on STM32 (#27111)" and now all works well. I did apply all other commits that were introduced at the same time: "U8G_SPI_USE_MODE_3 for *_MINI_12864", "USE_SOFTWARE_SPI => SDFAT_USE_SOFTWARE_SPI", "Misc. SPI cleanup". All of these did not create a problem. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
Marlin
bugfix-2.1.x
not compiling correctly since 3 weeks ago - BTT Octopus Pro V1.1 board.Expand me for log:
Bug Timeline
Started around 3 weeks ago
Expected behavior
I expected to compile clean. Did not made any changes to any files (configuration, pins, etc) before problem started occuring. Problem started after updating
bugfix-2.1.x
branch to the latest commits. To make sure there was no corruption, deleted repository and started a new repository but problem persists.Actual behavior
Did not compile clean. error shown on log above
Steps to Reproduce
Compile Marlin bugfix-2.1.x with board BTT Octopus Pro V1.1 (config and pins file attached.
Version of Marlin Firmware
bugfix-2.1.x
Printer model
Ender 5 Plus
Electronics
board BTT Octopus Pro V1.1
LCD/Controller
BigTreeTech TFT Touchscreen BTT_GD_TFT50_V3.0
Other add-ons
N/A
Bed Leveling
ABL Bilinear mesh
Your Slicer
Cura
Host Software
SD Card (headless)
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
Config and Pins Files.zip
The text was updated successfully, but these errors were encountered: