Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MKS SGEN L V2.0 / MKS TS35 V2.0 compile error #27182

Closed
1 task done
DragonLord1981 opened this issue Jun 16, 2024 · 11 comments · May be fixed by #27183
Closed
1 task done

[BUG] MKS SGEN L V2.0 / MKS TS35 V2.0 compile error #27182

DragonLord1981 opened this issue Jun 16, 2024 · 11 comments · May be fixed by #27183
Labels
Bug: Confirmed ! C: LCD & Controllers

Comments

@DragonLord1981
Copy link

DragonLord1981 commented Jun 16, 2024 •
edited
Loading

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

In file included from Marlin\src\HAL\LPC1768\tft\tft_spi.cpp:29:
Marlin\src\HAL\LPC1768\tft\tft_spi.h:38:4: error: #error "Invalid TFT SPI configuration."
38 | #error "Invalid TFT SPI configuration."

Bug Timeline

New for me

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

CONFIGURATION_H_VERSION 02010203

Printer model

Xvico

Electronics

MKS SGen L v2.0

LCD/Controller

MKS TS35 v2.0

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin.zip

No response
@thisiskeithb
Copy link
Member

Using the latest bugfix-2.1.x, replace /Marlin/Marlin/src/pins/lpc1769/pins_MKS_SGEN_L_V2.h with this file:
pins_MKS_SGEN_L_V2.h.zip

It compiles, but I haven't tested it on real hardware.

@thisiskeithb thisiskeithb changed the title [BUG] (bug summary) MKS SGen L v2.0/ MKS TS35 v2.0 [BUG] MKS SGEN L V2.0 / MKS TS35 V2.0 compile error Jun 16, 2024
@DragonLord1981
Copy link
Author

Perfect.. Thanks.. i will see if it works on the hardware :D

Using the latest bugfix-2.1.x, replace /Marlin/Marlin/src/pins/lpc1769/pins_MKS_SGEN_L_V2.h with this file: pins_MKS_SGEN_L_V2.h.zip

It compiles, but I haven't tested it on real hardware.

Perfect.. Thanks.. i will see if it works on the hardware :D

@DragonLord1981
Copy link
Author

Using the latest bugfix-2.1.x, replace /Marlin/Marlin/src/pins/lpc1769/pins_MKS_SGEN_L_V2.h with this file: pins_MKS_SGEN_L_V2.h.zip

It compiles, but I haven't tested it on real hardware.

Did kinda work bur got "err - eeprom"
And the screen is black no background light

@thisiskeithb
Copy link
Member

Did kinda work bur got "err - eeprom"

That's expected when you migrate major versions of Marlin and means you probably weren't running the latest bugfix-2.1.x before flashing.

And the screen is black no background light

I copied the pin layout from another pins file hoping EXP numbering would match up, so I'll have to look at this more closely when I wrap up some other work and can test on real hardware.

@ellensp
Copy link
Contributor

ellensp commented Jun 17, 2024 •
edited
Loading

#define TOUCH_BUTTONS_HW_SPI_DEVICE 1 should be 2

but other than that... it looks ok.

The back light not working doesn't make sense its just an IO pin, are you sure you plugged display exp1 to board exp1 and display exp2 to board exp2 correctly and not switched over?

NOTE Do not just switch these over. check it thoroughly

If you look at the pin diagram for MKS TS35 V2.0 https://github.com/makerbase-mks/MKS-TFT-Hardware/blob/master/MKS%20TS35/MKS%20TS35%20V2.0_001/MKS%20TS35%20V2.0_001%20PIN.pdf
You see that tft exp1 takes 5v as provided by the motherboard exp1 port
but tft exp2 can take 3.3v, if you plug this into motherboard exp1 you will most likely damage your display by putting 5v on the 3.3v line

@thisiskeithb thisiskeithb mentioned this issue Jun 17, 2024
Open
@thisiskeithb thisiskeithb linked a pull request Jun 17, 2024 that will close this issue
🐛 Fix/Improve SPI TFT support on MKS SGEN_L V2.0 #27183
Open
@thisiskeithb
Copy link
Member

See #27183 for the verified fix. There's still a quark with a BTT TFT35 SPI display on this motherboard, but I'll look into that later since it'll be a rare combination.

@DragonLord1981
Copy link
Author

TOUCH_BUTTONS_HW_SPI_DEVICE

Where do i find that setting ? and yes. the machin was working before update

@ellensp
Copy link
Contributor

ellensp commented Jun 17, 2024

In the originally provided updated pins_MKS_SGEN_L_V2.h.zip, it has been updated in #27183

@DragonLord1981
Copy link
Author

How do i download that file ? haha sorry.. i tried all the ways that i know

@thisiskeithb
Copy link
Member

How do i download that file ? haha sorry.. i tried all the ways that i know

Click on the download icon:

image

I've also attached it here:

pins_MKS_SGEN_L_V2.h.zip

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug: Confirmed ! C: LCD & Controllers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix/Improve SPI TFT support on MKS SGEN_L V2.0 thisiskeithb/Marlin
3 participants
@ellensp @thisiskeithb @DragonLord1981