Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Delta homing fails #25350

Closed
1 task done
Bob-the-Kuhn opened this issue Feb 6, 2023 · 6 comments
Closed
1 task done

[BUG] Delta homing fails #25350

Bob-the-Kuhn opened this issue Feb 6, 2023 · 6 comments

Comments

@Bob-the-Kuhn
Copy link
Contributor

Bob-the-Kuhn commented Feb 6, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Ever since PR #24951, delta printers may fail to home.

On my system, the fail happens when the head needs to move a long distance. The motors start moving and then all motors start buzzing, all motion stops and a homing error is declared.

The only work around I've found is to reduce the feedrates in HOMING_FEEDRATE_MM_M.

The git diff tool was used to narrow the failure point to PR #24951

89334caa526f2d300eee834d34d06d8f837a57d5 is the first bad commit
commit 89334caa526f2d300eee834d34d06d8f837a57d5
Author: tombrazier <68918209+tombrazier@users.noreply.github.com>
Date:   Mon Nov 28 03:38:15 2022 +0000

    ⚡️ Input Shaping improvements (#24951)

I looked through the PR #24951 changes and couldn't find anything obviously associated with delta printers.

This issue was uncovered in a post in the facebook group MarlinFirmware.

Bug Timeline

PR #24951

Expected behavior

Home properly using the HOMING_FEEDRATE_MM_M settings that worked prior to PR #24951.

Actual behavior

On my system, the fail happens when the head needs to move a long distance. The motors start moving and then all motors start buzzing, all motion stops and a homing error is declared.

Steps to Reproduce

  1. Create a delta printer configuration.
  2. Move the head by 100mm.
  3. Issue G28

Version of Marlin Firmware

bugfix-2.1.x from this morning

Printer model

Tevo Little Monster

Electronics

MKS_SBASE

Add-ons

Duet Smart Effector

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configs.zip

@Bob-the-Kuhn
Copy link
Contributor Author

I replaced stepper.h and stepper.cpp with pre-shaping versions. Now it works as expected.

@Bob-the-Kuhn
Copy link
Contributor Author

In stepper.h, reverting ISR_STEPPER_CYCLES back from 100UL to 16UL makes the latest bugfix-2.1.x work as expected.

@cbagwell
Copy link
Contributor

cbagwell commented Feb 8, 2023

#25335 should help; if not totally fix; for this case when input shaping is disabled at compile time.

@Bob-the-Kuhn
Copy link
Contributor Author

That also fixes it.

@thisiskeithb
Copy link
Member

Closing since the linked PR fixes this issue:

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants