Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Allen Key probe can't be used to Home Z #24370

Closed
1 task done
radry opened this issue Jun 19, 2022 · 3 comments
Closed
1 task done

[BUG] Allen Key probe can't be used to Home Z #24370

radry opened this issue Jun 19, 2022 · 3 comments

Comments

@radry
Copy link

radry commented Jun 19, 2022

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When using allen key probe type on a cartesian printer it can not be used as a Z_Min endstop and thus not be used to home Z.

This probe type is currently the only one useable in Marlin for dockable microswitch probes like klicky probe, quickdraw probe or euclid probe.

When configuring allen key probe in Marlin there are two issues:
First is the sanity check which claims this probe can't be used with Z_Min endstop. This can easily be commented out to compile the Firmware.
Second problem is when you try to home: It will refuse to Home Z and gives and "unhomed" error and claim it's necessary to Home Z first instead of deploying the probe and homing Z.

Bug Timeline

No response

Expected behavior

When using G28 it should home X, Y, then deploy the probe and home Z.

Actual behavior

After homing X, Y the printer will halt and claim it's necessary to Home Z instead of deploying the probe to do so.

Steps to Reproduce

  1. Configure to use Allen Key probe and set up a valid deploy and stow routine
  2. enable Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN
  3. Comment out the sanity check that prevents allen key probe to be used with Z_Min endstop
  4. Do G28

Version of Marlin Firmware

2.1

Printer model

custom corexy

Electronics

No response

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

SD Card (headless)

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin.zip

Related issues:
#24003
#22794

@radry
Copy link
Author

radry commented Jun 19, 2022

As a temporary solution I was able to get it running by changing probe.cpp

Line 424 and Line 459 from:
#if EITHER(Z_PROBE_SLED, Z_PROBE_ALLEN_KEY)

to
#if (Z_PROBE_SLED)

Now the probe correctly deploys and stows before/after homing Z.
Maybe additional safety checks are needed to ensure safe operation.

@thisiskeithb
Copy link
Member

#24420 has been merged.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants