Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] G34, Z_STEPPER_ALIGN_XY not updating properly through flashing firmware #23328

Closed
Luukver opened this issue Dec 21, 2021 · 5 comments
Closed

Comments

@Luukver
Copy link

Luukver commented Dec 21, 2021

Did you test the latest bugfix-2.0.x code?

No, but I will test it now!

Bug Description

The initial setup of the G34 probing coordinates worked fine (Z_STEPPER_ALIGN_XY), except one was a little too close to the edge so I changed it. After re-flashing the firmware on the BTT GTR the coordinates hadn't changed like I expected. instead the initial ones remained causing a lot of confusion as it seemed like Marlin was ignoring the configured values.

In combination with the probing margin configuration for mesh leveling this caused the G34 process to throw a probing error before moving to the changed position because the old position is now out of bounds. But because the new values are still stored somewhere the out of bounds error doesn't show causing further confusion.

What I've tried:

  • I've tried saving to EEPROM in case anything wasn't updated yet, didn't work.
  • I've tried adjusting Z_STEPPER_ALIGN_KNOWN_STEPPER_POSITIONS positions in case it was using that in any way even though it should be disabled. didn't work
  • I've tried removing the Probe margin configuration. didn't work

I did find a workaround:

  • Manually updating the probe coordinate in question using M422 S3 X<> Y<> seems to actually apply the updated value properly. Saving this to EEPROM also works.

Bug Timeline

New bug

Expected behavior

I expected the probing coordinates of the third axis to change according to the ones configured in Z_STEPPER_ALIGN_XY

Actual behavior

The old initial values remained regardless of whatever was configured in Configuration_adv.h

Steps to Reproduce

  1. Setup triple z-axis alignment with G34
  2. Configure the Z_STEPPER_ALIGN_XY values accordingly
  3. Flash the firmware to the board
  4. Change a coordinate (in this case the third axis)
  5. Re-Flash the firmware to the board
  6. Actual behavior of G34 hasn't changed compared to initial setup

Version of Marlin Firmware

2.0.7.2

Printer model

Custom

Electronics

BTT GTR V1.0 + BTT TFT35 V3.0

Add-ons

No response

Bed Leveling

ABL Bilinear mesh

Your Slicer

No response

Host Software

No response

Additional information & file uploads

Marlin.zip

@thisiskeithb
Copy link
Member

Did you test the latest bugfix-2.0.x code?
No, but I will test it now!

Version of Marlin Firmware
2.0.7.2

Please download bugfix-2.0.x to test with the latest code and let us know if you're still having this issue.

@ManuelMcLure
Copy link
Contributor

I believe the probe positions are saved in EEPROM which means you need to reinitialize the EEPROM after updating the probe positions in the config. Try M502 followed by M500 after updating the firmware and see if that solves the issue.

@Luukver
Copy link
Author

Luukver commented Dec 21, 2021

Please download bugfix-2.0.x to test with the latest code and let us know if you're still having this issue.

I will try the bug-fix version as soon as I can, updating the config files is somewhat tedious (any better way to do this?).

I believe the probe positions are saved in EEPROM which means you need to reinitialize the EEPROM after updating the probe positions in the config. Try M502 followed by M500 after updating the firmware and see if that solves the issue.

I just tried this and you're correct! M502 followed by M500 does update the values properly.
Still this shouldn't be a required step however.

@thisiskeithb
Copy link
Member

Still this shouldn't be a required step however.

It is when changing values stored in EEPROM.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants