Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BFT error after commit 08155b4 #22119

Closed
mriscoc opened this issue Jun 12, 2021 · 5 comments
Closed

[BUG] BFT error after commit 08155b4 #22119

mriscoc opened this issue Jun 12, 2021 · 5 comments

Comments

@mriscoc
Copy link
Contributor

mriscoc commented Jun 12, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

Binary File Transfer add a 00 00 to the start of the files and then replace 00 00 each 512 bytes to the file saved on the SD card.
That behavior is present only after apply the commit 08155b4 and compile with the STM32F103RET6_creality environment.

Compiling with STM32F103RET6_creality_maple the BFT error is not present.

Version of Marlin Firmware

Latest bugfix 2.0.x

Printer model

Creality Ender 3v2

Electronics

STM32F103RET6

Host Software

OctoPrint

Additional information & file uploads

With: python ./transfer.py TEST.GCO -b 250000 -p /dev/ttyUSB0 -d 50 -c
There is an error in the saved file.

With: python ./transfer.py TEST.GCO -b 250000 -p /dev/ttyUSB0 -d 50
The file is saved ok.

Then, could be an error in the compression buffer?

@mriscoc mriscoc changed the title [BUG] BFT error after commit 08155b4875fdb08f1888cacae6e1b68b48b9e51f [BUG] BFT error after commit 08155b4 Jun 12, 2021
@mriscoc
Copy link
Contributor Author

mriscoc commented Jun 14, 2021

Environment STM32F103RET6_creality fails to define ARDUINO_ARCH_STM32F1 that is necessary for the binary_stream.h conditional compile:
#if BOTH(ARDUINO_ARCH_STM32F1, SDIO_SUPPORT)

credits to p3p

@ellensp
Copy link
Contributor

ellensp commented Jun 14, 2021

Confirmed.
I just changed the #if BOTH(ARDUINO_ARCH_STM32F1, SDIO_SUPPORT) to #if 1
And tested. Compressed uploads are no longer corrupt

@ellensp
Copy link
Contributor

ellensp commented Jun 14, 2021

#if EITHER(ARDUINO_ARCH_STM32F1, STM32F1) && ENABLED(SDIO_SUPPORT)

should fix it, just testing.
edit: yes this works.

@ellensp
Copy link
Contributor

ellensp commented Jun 15, 2021

A fix has been merged. closing

@ellensp ellensp closed this as completed Jun 15, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants