Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support second UART to have other bitrate #21006

Closed
Teddyz opened this issue Feb 5, 2021 · 2 comments
Closed

[FR] Support second UART to have other bitrate #21006

Teddyz opened this issue Feb 5, 2021 · 2 comments
Labels
C: Serial Comms T: Feature Request Features requested by users.

Comments

@Teddyz
Copy link

Teddyz commented Feb 5, 2021

Description

Make it possible to have SERIAL_PORT_2 using a new setting BAUDRATE_2

Feature Workflow

I think this code in MarlinCore.cpp will solve this:

  #if HAS_MULTI_SERIAL
    #if defined(BAUDRATE_2)
      MYSERIAL1.begin(BAUDRATE_2);
    #else
      MYSERIAL1.begin(BAUDRATE);
    #endif
    serial_connect_timeout = millis() + 1000UL;
    while (!MYSERIAL1 && PENDING(millis(), serial_connect_timeout)) { /*nada*/ }
  #endif

Configuration.h:

#define BAUDRATE 250000
#define BAUDRATE_2 9600

Additional Information

Some documentation in Configuration.h is needed.
I did some basic testing on my Mega2560-board (Trigorilla_14) and it seems to work, but I am no expert.

@Teddyz Teddyz added the T: Feature Request Features requested by users. label Feb 5, 2021
@thisiskeithb
Copy link
Member

Implemented in #21949

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: Serial Comms T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

2 participants