Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create a PR against bugfix-2.0.x branch #153

Closed
hub-jba opened this issue Jul 15, 2020 · 6 comments
Closed

Unable to create a PR against bugfix-2.0.x branch #153

hub-jba opened this issue Jul 15, 2020 · 6 comments

Comments

@hub-jba
Copy link
Contributor

hub-jba commented Jul 15, 2020

Hi I have created some configurations to support an extensible ui port of the AI3M code base (PR on marlinfw here: MarlinFirmware/Marlin#18655). The corresponding configurations to support this build are sitting in my repo here: https://github.com/hub-jba/Configurations

I'm trying to generate a PR for my added configs against the Configurations repo, but I don't think I am able to do so.

@chepo92
Copy link
Contributor

chepo92 commented Jul 15, 2020

Be specific, what stops you? are you targeting the default branch (import)

@hub-jba
Copy link
Contributor Author

hub-jba commented Jul 15, 2020

I was trying to target the bugfix-2.0.x branch but I have been told to target the default branch (import) instead on discord. Will do so now

@hub-jba hub-jba closed this as completed Jul 15, 2020
@chepo92
Copy link
Contributor

chepo92 commented Jul 15, 2020

@hub-jba
Copy link
Contributor Author

hub-jba commented Jul 15, 2020

Not sure if this is being serious or said to be funny, but for clarity's sake, I was simply trying to follow the convention set in the main marlin repository for which the far more accessible instructions on the website were very clear that you should be making PR's against the bugfix-2.0 branch. On top of that the import-2.0.x branch is rather confusingly named. Makes it look like someone set that branch up for the initial import and then forgot to change the default on the repo, which is what I had assumed happened.

@chepo92
Copy link
Contributor

chepo92 commented Jul 15, 2020

You didn't do the search, hahahah, I had the same thinking some months ago, #81
I agree it is a bit confusing, I dont't know what happened, as always, ideas and PR's are welcomed

@hub-jba
Copy link
Contributor Author

hub-jba commented Jul 15, 2020

Lol, that is funny to see that you had the exact same experience as me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants