Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tab not intuitive (UI improvement) #16

Closed
chaosarium opened this issue Nov 20, 2022 · 1 comment · Fixed by #28
Closed

Rename tab not intuitive (UI improvement) #16

chaosarium opened this issue Nov 20, 2022 · 1 comment · Fixed by #28
Assignees
Labels
enhancement New feature or request React UI Change in UI Layer is needed

Comments

@chaosarium
Copy link
Collaborator

I couldn't figure out how to rename a tab without searching through the documentation. alt + left click is probably not something people think of.

Maybe double click or right click menu with rename option would be more intuitive.

@MarkChenYutian MarkChenYutian added the enhancement New feature or request label Nov 20, 2022
@MarkChenYutian
Copy link
Owner

This behavior is defined in here, specifically:

onTabClick: (key: string, e) => {
// TODO: Find some way to let alt-key (second key click) toggle rename
if (e.altKey) {
const s = prompt("File name for tab:");
this.props.setTabName(parseInt(key), s === null ? "" : s)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request React UI Change in UI Layer is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants