Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fontawesome version to latest (v6) from v5 #2242

Closed
yucheng11122017 opened this issue Mar 27, 2023 · 5 comments · Fixed by #2326
Closed

Upgrade fontawesome version to latest (v6) from v5 #2242

yucheng11122017 opened this issue Mar 27, 2023 · 5 comments · Fixed by #2326
Assignees
Labels
c.Feature 🚀 d.chore p.High To be done in the next few releases

Comments

@yucheng11122017
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

Author Usability

Is your feature request related to a problem? Please describe.

Currently Markbind is using only v5 of fontawesome.
v6 of fontawesome added quite a number of new features which could be useful to users.

Describe the solution you'd like

Upgrade fontawesome from v5 to v6

Instructions here:
https://fontawesome.com/docs/web/setup/upgrade/

Describe alternatives you've considered

No response

Additional context

No response

@damithc
Copy link
Contributor

damithc commented Jul 12, 2023

If this can be done quickly, it would be good to have it in MarkBind v5.0
It appears some icons in FontAwsome V5 are not in V6. Is it possible to support both versions? OK if cannot but it will break some of the existing sites silently. In fact, it would be good to give a warning if an icon cannot be found.
If the upgrade can't be done in time for MarkBind v5.0, perhaps we can update the UG to inform users that they should use FontAwsome V5 for the time being.

@tlylt tlylt added p.High To be done in the next few releases and removed p.Low labels Jul 12, 2023
@SPWwj
Copy link
Contributor

SPWwj commented Jul 13, 2023

I may help with this, since it is related to what I am currently doing

@damithc
Copy link
Contributor

damithc commented Jul 13, 2023

@SPWwj sure

@tlylt
Copy link
Contributor

tlylt commented Jul 14, 2023

I may help with this, since it is related to what I am currently doing

@SPWwj Any plan to finish this one soon? We will target to release v5 by this weekend.

@SPWwj
Copy link
Contributor

SPWwj commented Jul 14, 2023

That's quite rushed. I will revisit this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature 🚀 d.chore p.High To be done in the next few releases
Projects
None yet
5 participants