From 59e046a132288d4a3a243816919b451cc3de7de2 Mon Sep 17 00:00:00 2001
From: Jovyn Tan <jovyn.tls@gmail.com>
Date: Fri, 17 Mar 2023 17:51:46 +0800
Subject: [PATCH] minor refactor

---
 packages/core/src/html/siteAndPageNavProcessor.ts | 9 ++++-----
 packages/core/src/html/vueSlotSyntaxProcessor.ts  | 5 ++---
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/packages/core/src/html/siteAndPageNavProcessor.ts b/packages/core/src/html/siteAndPageNavProcessor.ts
index 45aacb53ba..7cd7f7f2d3 100644
--- a/packages/core/src/html/siteAndPageNavProcessor.ts
+++ b/packages/core/src/html/siteAndPageNavProcessor.ts
@@ -1,7 +1,6 @@
 import { v4 as uuidv4 } from 'uuid';
-import { DomElement } from 'htmlparser2';
 import cheerio from 'cheerio';
-import { MbNode, parseHTML } from '../utils/node';
+import { MbNode, NodeOrText, parseHTML, TextElement } from '../utils/node';
 
 require('../patches/htmlparser2');
 const md = require('../lib/markdown-it');
@@ -39,7 +38,7 @@ const SITE_NAV_DROPDOWN_ICON_ROTATED_HTML = '<div class="site-nav-dropdown-btn-c
  * otherwise it is replaced with one until it is unique.
  */
 export class PageNavProcessor {
-  uuidTextNode?: DomElement;
+  uuidTextNode?: TextElement;
 
   getUuid() {
     return (this.uuidTextNode && this.uuidTextNode.data) || '';
@@ -47,10 +46,10 @@ export class PageNavProcessor {
 
   renderPageNav(node: MbNode) {
     [this.uuidTextNode] = parseHTML(uuidv4());
-    cheerio(node).replaceWith(this.uuidTextNode as MbNode);
+    cheerio(node).replaceWith(this.uuidTextNode as cheerio.Element);
   }
 
-  finalizePageNavUuid(mainHtml: string | null, mainHtmlNodes: DomElement[], footnotesHtml: string) {
+  finalizePageNavUuid(mainHtml: string | null, mainHtmlNodes: NodeOrText[], footnotesHtml: string) {
     if (!this.uuidTextNode) {
       return mainHtml;
     }
diff --git a/packages/core/src/html/vueSlotSyntaxProcessor.ts b/packages/core/src/html/vueSlotSyntaxProcessor.ts
index 5877df7bf9..8e23d429c3 100644
--- a/packages/core/src/html/vueSlotSyntaxProcessor.ts
+++ b/packages/core/src/html/vueSlotSyntaxProcessor.ts
@@ -30,11 +30,10 @@ export function shiftSlotNodeDeeper(node: MbNode) {
   nodeChildren.forEach((child) => {
     const vslotShorthandName = getVslotShorthandName(child);
     if (vslotShorthandName && child.name !== 'template') {
-      const newSlotNode = parseHTML('<template></template>')[0];
+      const newSlotNode = parseHTML('<template></template>')[0] as MbNode;
 
       const vslotShorthand = `#${vslotShorthandName}`;
 
-      newSlotNode.attribs = newSlotNode.attribs ?? {};
       newSlotNode.attribs[vslotShorthand] = '';
       if (child.attribs) {
         delete child.attribs[vslotShorthand];
@@ -43,7 +42,7 @@ export function shiftSlotNodeDeeper(node: MbNode) {
       newSlotNode.parent = node;
       child.parent = newSlotNode;
 
-      newSlotNode.children = newSlotNode?.children ?? [];
+      newSlotNode.children = newSlotNode.children ?? [];
       newSlotNode.children.push(child);
 
       // replace the shifted old child node with the new slot node