CSLA calls operations of base classes

[StefanOssendorf]

I'm wondering if this is a bug or a feature.

public abstract class FooBase : BusinessBase<FooBase> {
  [Create]
  private void CreateBase() {
  }
}

public class Foo : FooBase {
}


IDataPortal<Foo> x;
var foo = await x.CreateAsync(); // This calls CreateBase()

Should the CreateBase() method be considered the Create operation of Foo? For me that looks like invoking a "constructor" only from the base class but not from the actual class which could create a lot of trouble.

Edit: The same holds for non abstract classes, too. So "removing" a CSLA operation attribute is not necessarily an option.

[rockfordlhotka]

I think you are suggesting that the data portal should not honor data portal operation attributes inherited from base types?

That does seem like it should make for more understandable code.

Originally, before the modern attribute scheme, the data portal relied on overrides of base methods like DataPortal_Create, and the base classes provided default implementations of (specifically) create. That is no longer valid, and those base class defaults are now gone.

My first instinct is to say that this is a bug - unintended behavior.

[StefanOssendorf]

@rockfordlhotka
Just to sum this up.
This is unintended and we'll create an issue to get this changed in the future?

[rockfordlhotka]

@StefanOssendorf yes, would you please create an issue?

[StefanOssendorf]

Yes. I'll create an isseu for that.

[StefanOssendorf]

#4090
Created :)

[michaelcsikos]

I would still expect protected to resolve without virtual. It's visible and can be called from an inheriting class.